Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MHLO machinery for printing array refs into AssemblyFormat #485

Closed
GleasonK opened this issue Nov 8, 2022 · 3 comments
Closed

Move MHLO machinery for printing array refs into AssemblyFormat #485

GleasonK opened this issue Nov 8, 2022 · 3 comments
Assignees
@GleasonK
Labels
Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit Prettyprinting

Comments

@GleasonK
Copy link
Member

GleasonK commented Nov 8, 2022

Request description

Found in #403. Move printing machinery for array refs to AssemblyFormat.h. Currently we have printDenseI64Array, which works for I64ElementsAttr and BroadcastDimsAttr but not for def StableHLO_Dim : ArrayRefParameter<"int64_t", "Dimension">;

As a follow-up change the HLODim printing to use this new functionality as suggested in #403.
@GleasonK GleasonK mentioned this issue Nov 8, 2022
Merged
@burmako burmako added the Migrate to MHLO PR that needs to be migrated to MLIR-HLO label Nov 8, 2022
@burmako
Copy link
Contributor

burmako commented Nov 8, 2022

Once done, let's use the new assembly format in OutputOperandAlias. See #403 for context.

@burmako burmako added Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit and removed Migrate to MHLO PR that needs to be migrated to MLIR-HLO labels Nov 13, 2022
@burmako burmako linked a pull request Nov 14, 2022 that will close this issue
Add parser for StableHLO_Dim #546
Merged
copybara-service bot pushed a commit to tensorflow/mlir-hlo that referenced this issue Nov 15, 2022
Integrate StableHLO at openxla/stablehlo@2813676bbbc8
c1b8463 
Manually updated files:
  * stablehlo/dialect/StablehloAttrs.td
  * stablehlo/dialect/StablehloOps.cpp
  * stablehlo/dialect/StablehloOps.h

Manual updates were needed (and will be needed) until openxla/stablehlo#485 is fixed.

PiperOrigin-RevId: 488667219
copybara-service bot pushed a commit to google/tsl that referenced this issue Nov 15, 2022
@copybara-github
Integrate StableHLO at openxla/stablehlo@2813676bbbc8
b164edf 
Manually updated files:
  * stablehlo/dialect/StablehloAttrs.td
  * stablehlo/dialect/StablehloOps.cpp
  * stablehlo/dialect/StablehloOps.h

Manual updates were needed (and will be needed) until openxla/stablehlo#485 is fixed.

PiperOrigin-RevId: 488667219
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this issue Nov 15, 2022
@tensorflower-gardener
Integrate StableHLO at openxla/stablehlo@2813676bbbc8
24bff0d 
Manually updated files:
  * stablehlo/dialect/StablehloAttrs.td
  * stablehlo/dialect/StablehloOps.cpp
  * stablehlo/dialect/StablehloOps.h

Manual updates were needed (and will be needed) until openxla/stablehlo#485 is fixed.

PiperOrigin-RevId: 488667219
@burmako burmako removed a link to a pull request Nov 16, 2022
Add parser for StableHLO_Dim #546
Merged
@burmako
Copy link
Contributor

burmako commented Nov 16, 2022

The migrate from MHLO part is done in #546, which has just been merged. As discussed, there's still the matter of sharing this machinery with MHLO via AssemblyFormat.h.

@GleasonK
Copy link
Member Author

GleasonK commented Feb 1, 2023

Fixed in tensorflow/mlir-hlo@c1f1538

@GleasonK GleasonK closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleasonK GleasonK

Labels
Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit Prettyprinting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burmako @GleasonK