-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document compatibility guarantees #4
Comments
Quick update on the progress with this ticket, because I know that some community members are eagerly awaiting compatibility guarantees from StableHLO:
|
The most challenging part of M1 (see above) is done. StableHLO now has Python bindings, has been integrated into the MLIR-HLO repository, and both CMake and Bazel builds are working over there. This enabled JAX to start using StableHLO's Python bindings (jax-ml/jax@12cb55d). At the moment, JAX is only using the CHLO dialect from the StableHLO repository, and next week I'm planning to work with @hawkinsp to also add a StableHLO lowering. (This will need a conversion from StableHLO to MHLO which I hoped to land this week, but I'll need to travel this weekend, so landing got pushed back to early next week). On a related note, @GleasonK has started working on #34 to explore the newly introduced binary serialization functionality in MLIR upstream, which will be crucial for our compatibility work. Kevin and I will be working on compatibility guarantees together, along the timeline discussed above (sharing a proposal by EOW 9/4 or a bit later, starting a community discussion around that). |
Handing this off to @GleasonK who has made great progress with binary serialization for StableHLO and CHLO in #60 and #66. Now that we have a concrete implementation of this, we can talk about compatibility in more detail. Versioning work is still ongoing upstream, but there's already plenty to talk about even before it materializes in an RFC. |
Spoke with @burmako. The purpose of this issue was surrounding creating a proposal, as stated in a previous comment:
In that regard, this issue is complete as the markdown proposal exists in #115. Discussion of requirements and conversation around finalizing compatibility guarantees should take place on #115. Closing this issue to avoid any duplication. |
As discussed in #1, one of the main reasons for introducing StableHLO is being able to provide compatibility guarantees for MHLO while keeping MHLO as flexible as possible. This is something that we can start doing right now, and within this ticket I'll work on putting together a proposal for what this means exactly.
The text was updated successfully, but these errors were encountered: