-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-statsd-exporter: add new package #7635
Conversation
See |
@dhewg thanks for your work! Did you check if the clean works locally? Maybe Go puts some special access flags so no other programs/user interfere while it's compiling stuff? Maybe |
@aparcar Yeah, I get the same permission problem locally. |
Sorry I'm no go pro neither, I think the build system doesn't swap users while building... |
Looking at the golang history, maybe @jefferyto knows? |
I think the issue is golang/go#27455 - I'll need to add a call to |
That indeed sounds like the issue. "Working as intented", I don't even... |
Looking at the build output - it seems that our SDK's have |
Then that's why it fails for me locally (I have it set because I build on a ramdisk) |
go 1.11 added modules, which are cached locally. The go developers have decided to make this cache read-only (golang/go#27455), which causes problems with package clean / autoremove (openwrt#7635). This adds a call to clear this cache right after building, as currently there is no easy way to hook into autoremove (it may be possible to hook into package clean). This also adds whitespace (blank lines) to certain places in make output, to aid debugging. Signed-off-by: Jeffery To <[email protected]>
statsd_exporter receives StatsD-style metrics and exports them as Prometheus metrics. Signed-off-by: Andre Heider <[email protected]>
84c7e55
to
b57f6b1
Compare
Thanks for the quick fix! Rebased to force a rebuild, and it builds fine now ;) |
go 1.11 added modules, which are cached locally. The go developers have decided to make this cache read-only (golang/go#27455), which causes problems with package clean / autoremove (openwrt#7635). This adds a call to clear this cache right after building, as currently there is no easy way to hook into autoremove (it may be possible to hook into package clean). This also adds whitespace (blank lines) to certain places in make output, to aid debugging. Signed-off-by: Jeffery To <[email protected]>
statsd_exporter receives StatsD-style metrics and exports them as Prometheus
metrics.
Signed-off-by: Andre Heider [email protected]
Maintainer: @aparcar (for related prometheus)
Compile tested: arm/sunxi, Cubieboard 2, master
Run tested: arm/sunxi, Cubieboard 2, master, asterisk<->prometheus interop
Description:
Not ready yet for merging! While the package is built, there's an issue with
make clean
because all the files in$BUILD_DIR/.go_work/build/pkg/mod
are not writable, so they cannot be removed. I'm not sure what the root cause is, anyone got an idea?Apart from that, the resulting package works fine, and I'm using it with the openwrt asterisk packages. Asterisk doesn't support prometheus metrics directly, but has various statsd modules. Using those to push to this exporter, I can scrape from prometheus successfully. Asterisk statsd->prometheus label mapping are included in the yml config file.