Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method get_port #16

Closed
birdsarah opened this issue Apr 7, 2020 · 5 comments
Closed

Add new method get_port #16

birdsarah opened this issue Apr 7, 2020 · 5 comments
Assignees

Comments

@birdsarah
Copy link
Collaborator

Report back a port, if it was in the netloc.

@yabirgb
Copy link
Contributor

yabirgb commented Apr 8, 2020

What is the expected behave if there is no port in the netloc?

@birdsarah
Copy link
Collaborator Author

I think returning None is fine for now.

@birdsarah
Copy link
Collaborator Author

For context @yabirgb this is a library I'm actively using along with colleagues for now I'm happy to get a starting point for an API, put it in, see how it works in practice when doing analysis and tweak the API if necessary. My plan is to let everything bake for a few months and then move to 1.0 once we've stabilized and feel good about committing to an API.

@birdsarah
Copy link
Collaborator Author

For context @yabirgb this is a library I'm actively using along with colleagues for now I'm happy to get a starting point for an API, put it in, see how it works in practice when doing analysis and tweak the API if necessary.

If you're using the library, I'm also more than happy to hear your thoughts.

@birdsarah
Copy link
Collaborator Author

closed via #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants