You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, altering the trait instance label name on a resource definition is flagged as a warning by the compiler:
E.g Changing the LabelSettingsTrait instance 'device_label' to 'device_label_moved':
WARNING:root:RemovedObjectValidator has validation warnings:
Previous schema item weave.resource.service.DescriptionServiceResource.device_label is missing from current schema. Schema items cannot be removed without breaking backward compatibility.
On the service layer, this change is actually deemed a breaking change since the labels are used to index into their data storage layer.
Consequently, the WDL compiler should be modified to flag this appropriately.
The text was updated successfully, but these errors were encountered:
Before we move forward with this, was that indexing choice an ecosystem-specific implementation choice and, as such, should this be a -Werror=device-label-moved option that ecosystems can specific to the extent they made such a choice?
Currently, altering the trait instance label name on a resource definition is flagged as a warning by the compiler:
E.g Changing the LabelSettingsTrait instance 'device_label' to 'device_label_moved':
On the service layer, this change is actually deemed a breaking change since the labels are used to index into their data storage layer.
Consequently, the WDL compiler should be modified to flag this appropriately.
The text was updated successfully, but these errors were encountered: