Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fixed version or user provided openthread source to make cirque behavior stable #16

Open
erjiaqing opened this issue Sep 28, 2020 · 0 comments

Comments

@erjiaqing
Copy link
Contributor

function install_openthread() {
if [ ! -d "${OPEN_THREAD_DIR}" ]; then
wget https://github.com/openthread/openthread/archive/master.zip
unzip master.zip
rm master.zip
mv openthread-master openthread
fi
pushd .
cd openthread
./bootstrap
make -f examples/Makefile-simulation
popd
}

Currently, cirque always download openthread's master code, which is not stable since change in openthread will break cirque.

There are two ways that can make this better,

  1. Use a fixed openthread commit id and update it regularly,
  2. Allow user specify the path of openthread and use it here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant