Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master secret to link secret #1410

Closed
TimoGlastra opened this issue Mar 29, 2023 · 2 comments · Fixed by #1415
Closed

Update master secret to link secret #1410

TimoGlastra opened this issue Mar 29, 2023 · 2 comments · Fixed by #1415
Assignees
Milestone

Comments

@TimoGlastra
Copy link
Contributor

          When you call create credential request in indy-sdk / anoncreds rs) it will return the following metadata:
{
          "master_secret_blinding_data": {
            "v_prime": "6088566065720309491695644944398283228337587174153857313170975821102428665682789111613194763354086540665993822078019981371868225077833338619179176775427438467982451441607103798898879602785159234518625137830139620180247716943526165654371269235270542103763086097868993123576876140373079243750364373248313759006451117374448224809216784667062369066076812328680472952148248732117690061334364498707450807760707599232005951883007442927332478453073050250159545354197772368724822531644722135760544102661829321297308144745035201971564171469931191452967102169235498946760810509797149446495254099095221645804379785022515460071863075055785600423275733199",
            "vr_prime": null
          },
          "nonce": "131502096406868204437821",
          "master_secret_name": "walletId28c602347-3f6e-429f-93cd-d5aa7856ef3f"
        }

If we move to using link secret in AnonCreds RS, we should update all metadata and transform the master_secret keys to link_secret keys in the Indy SDK holder service in AFJ.

Did you also update these fields in your link secret pr in anoncreds rs?

Originally posted by @TimoGlastra in #1392 (comment)

@TimoGlastra TimoGlastra added this to the 0.4.0 milestone Mar 29, 2023
@TimoGlastra
Copy link
Contributor Author

  1. Release new version of AnonCreds Rust
  2. Update field names in AFJ
  1. handle difference between field names in indy-sdk (still master_secret) and anoncreds rs (link_secret). Probably extending the migration script to update indy-sdk generated request metadata to use link_secret, and from now in the indy-sdk when returning the credential request metadata we chagne the keys.

@TimoGlastra
Copy link
Contributor Author

@TimoGlastra will make AnonCreds RS release, @genaris will integrate into AFJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants