Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set token for deployment #174

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Mar 12, 2024

The release workflow will update the code by writing a new version number to the files. But since we have a protection rule on the main branch, we can not push directly. So the solution is to use a personal github token where the user is authorised to bypass the call.

In the future it would be better to use an app for this, see this discussion.
https://github.com/orgs/community/discussions/13836

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (42a10c1) to head (8f696b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          23       23           
  Lines        2082     2082           
  Branches      307      307           
=======================================
  Hits         2041     2041           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasjhan
Copy link
Member

LGTM :)

@lukasjhan lukasjhan merged commit d097f8c into openwallet-foundation:main Mar 12, 2024
10 checks passed
@cre8 cre8 deleted the fix/release branch April 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants