Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer auth 'code' overriding auth_type 'bearer' #255

Closed
dmitrizagidulin opened this issue Nov 4, 2022 · 2 comments
Closed

Issuer auth 'code' overriding auth_type 'bearer' #255

dmitrizagidulin opened this issue Nov 4, 2022 · 2 comments
Assignees

Comments

@dmitrizagidulin
Copy link
Contributor

To reproduce:

Load up a local build from latest main.
Click on deeplink: dccrequest://request?issuer=issuer.example.com&vc_request_url=https://verify.dcconsortium.org/request/credential&challenge=ke12345678-0001&auth_type=bearer

Expected behavior: You should receive the VC from the issuer (since it's using bearer auth).
Actual behavior: Instead, you're shown a 'Log in with Google' prompt, with the wallet acting as if auth_type=code.

I suspect this is due to requestCredential() having auth_type=code by default. And the callback mechanism is somehow not passing in the right auth_type.

@sethduffin
Copy link
Contributor

@dmitrizagidulin I was not able to reproduce this specific issue, let me know if I you see this again, or if I should keep looking into it.

@dmitrizagidulin
Copy link
Contributor Author

@sethduffin - no prob, going to close it for the time being; will reopen if we encounter it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants