Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PaddlePaddle Hackathon 3】Add Paddle p_norm operator #12299

Merged
merged 4 commits into from
Sep 13, 2022
Merged

【PaddlePaddle Hackathon 3】Add Paddle p_norm operator #12299

merged 4 commits into from
Sep 13, 2022

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Jul 26, 2022 •
edited
Loading

@Asthestarsfalll Asthestarsfalll requested a review from a team as a code owner July 26, 2022 08:02
@Asthestarsfalll Asthestarsfalll mentioned this pull request Jul 26, 2022
Closed
openvino-dev-samples
openvino-dev-samples reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@openvino-dev-samples openvino-dev-samples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

src/frontends/paddle/src/op/p_norm.cpp Outdated Show resolved Hide resolved
@yuxu42
Copy link
Contributor

yuxu42 commented Aug 1, 2022

@liubo-intel Could you please take a review? Thanks!

@Asthestarsfalll
Copy link
Contributor Author

@liubo-intel
Could you please take a review? Thanks!

liubo-intel
liubo-intel reviewed Aug 6, 2022
View reviewed changes
Copy link
Contributor

@liubo-intel liubo-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Asthestarsfalll : Thanks for contribution. Please fix CI clang-format issue of this PR( [clang-format] Code style check failed for:
/home/runner/work/openvino/openvino/src/frontends/paddle/src/op/p_norm.cpp). you can find this failure information by click "Details" button of bellow related failed CI checks or with "-DENABLE_CLANG_FORMAT=ON -DENABLE_NCC_STYLE=ON" CMake Options when build openvino source code.

src/frontends/paddle/src/op/p_norm.cpp Show resolved Hide resolved
@liubo-intel liubo-intel added category: PDPD FE OpenVINO PaddlePaddle FrontEnd PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event labels Aug 6, 2022
@liubo-intel
Copy link
Contributor

@Asthestarsfalll : looks like there is some issue on CI, could you please rebase this PR to the latest master branch? thanks.

@Asthestarsfalll Asthestarsfalll requested review from a team as code owners August 19, 2022 05:28
@Asthestarsfalll Asthestarsfalll requested review from isanghao and iefode and removed request for a team August 19, 2022 05:28
@liubo-intel
Copy link
Contributor

Hi, @ceciliapeng2011 : do you have any other comments about this PR? if none, could you please help merge it? tks.

@Asthestarsfalll Asthestarsfalll requested a review from a team as a code owner September 5, 2022 04:23
ilyachur
ilyachur reviewed Sep 5, 2022
View reviewed changes
src/frontends/paddle/src/op/p_norm.cpp Outdated Show resolved Hide resolved
src/frontends/paddle/src/op/p_norm.cpp Outdated Show resolved Hide resolved
src/frontends/paddle/src/op/p_norm.cpp Outdated Show resolved Hide resolved
src/frontends/paddle/src/op/p_norm.cpp Outdated Show resolved Hide resolved
@ceciliapeng2011 ceciliapeng2011 self-assigned this Sep 13, 2022
@ceciliapeng2011 ceciliapeng2011 added this to the 2022.3 milestone Sep 13, 2022
@pmilewsk pmilewsk merged commit b9e2f28 into openvinotoolkit:master Sep 13, 2022
@Asthestarsfalll Asthestarsfalll deleted the p_norm branch September 14, 2022 03:39
@ilya-lavrenov ilya-lavrenov added the ExternalPR External contributor label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@openvino-dev-samples openvino-dev-samples openvino-dev-samples left review comments

@liubo-intel liubo-intel liubo-intel approved these changes

@ceciliapeng2011 ceciliapeng2011 ceciliapeng2011 approved these changes

@ilyachur ilyachur ilyachur approved these changes

Assignees

@ceciliapeng2011 ceciliapeng2011

Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event
Projects
None yet
Milestone
2022.3
Development

Successfully merging this pull request may close these issues.
8 participants
@Asthestarsfalll @yuxu42 @liubo-intel @ilyachur @ceciliapeng2011 @openvino-dev-samples @ilya-lavrenov @pmilewsk