Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[core] Preserve friendly name and tensor names in PPP" #28069

Closed
wants to merge 1 commit into from
Closed

Revert "[core] Preserve friendly name and tensor names in PPP" #28069

wants to merge 1 commit into from

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Dec 13, 2024 •
edited
Loading

@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Dec 13, 2024
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners December 13, 2024 16:49
@ilya-lavrenov ilya-lavrenov requested review from itikhono and removed request for a team December 13, 2024 16:49
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations labels Dec 13, 2024
@dorloff dorloff self-requested a review December 13, 2024 18:26
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Dec 13, 2024
@ilya-lavrenov ilya-lavrenov removed this pull request from the merge queue due to a manual request Dec 13, 2024
@praasz
Copy link
Contributor

praasz commented Dec 16, 2024 •
edited
Loading

Proposal fix in PR with modified OpenVINO tokenizers:

@praasz praasz mentioned this pull request Dec 16, 2024
Merged
@ilya-lavrenov ilya-lavrenov deleted the revert-23713-bugfix/fix-ppp-dereferences-input-tensor-names branch December 16, 2024 13:20
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Dec 16, 2024
@praasz
Fix test fails after PPP stops move tensor names (#1390)
b48ad93 
###  Description:
- Fix the GENAI test after PPP don't move Node's name and tensor names.

### Related PRs:
- openvinotoolkit/openvino_tokenizers#352
- openvinotoolkit/openvino#28069

---------

Signed-off-by: Raasz, Pawel <[email protected]>
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Dec 16, 2024
@praasz
Fix test fails after PPP stops move tensor names (#1390)
03d1ef8 
###  Description:
- Fix the GENAI test after PPP don't move Node's name and tensor names.

### Related PRs:
- openvinotoolkit/openvino_tokenizers#352
- openvinotoolkit/openvino#28069

---------

Signed-off-by: Raasz, Pawel <[email protected]>
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Dec 16, 2024
@praasz
Fix test fails after PPP stops move tensor names (#1390)
2a52e86 
###  Description:
- Fix the GENAI test after PPP don't move Node's name and tensor names.

### Related PRs:
- openvinotoolkit/openvino_tokenizers#352
- openvinotoolkit/openvino#28069

---------

Signed-off-by: Raasz, Pawel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorloff dorloff dorloff approved these changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

Assignees

@mlukasze mlukasze

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph) category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations do_not_merge
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ilya-lavrenov @praasz @dorloff @mlukasze