[NPUW] Port unroll SDPA optimization from GenAI #27891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: NPU
dmatveev
changed the title
|
@AsyaPronina please pick titles carefully. |
AsyaPronina
force-pushed
the
copy_unroll_sdpa_to_npuw_llm_comp_model
branch
from
772ebef to
a4b0b81
Compare
|
@TolyaTalamanov please review |
|
@TolyaTalamanov gentle reminder |
TolyaTalamanov
approved these changes
Dec 20, 2024
| for (auto tensor : model->inputs()) { | ||
| if (tensor.get_any_name().find("past_key") != std::string::npos) { | ||
| ppp.input(tensor.get_any_name()).tensor().set_element_type(ov::element::Type_t::f16); | ||
| class ScaledDotProductAttentionDecomposition : public ov::pass::MatcherPass { |
There was a problem hiding this comment.
The pass was initially taken from GPU plugin. Should we re-use already existing pass instead?
|
|
||
| LOG_DEBUG("3. Creating prefill model as clone of transformed kvcache one."); | ||
| LOG_DEBUG("3. Align u4 ZP constants."); | ||
| align_u4_zp_constants(kvcache_model); |
There was a problem hiding this comment.
I believe it's no longer needed
|
@AsyaPronina please resolve the conflicts and address @TolyaTalamanov latest comments here. |
AsyaPronina
force-pushed
the
copy_unroll_sdpa_to_npuw_llm_comp_model
branch
from
b06e640 to
d4b5c4b
Compare
|
Ready! |
AsyaPronina
force-pushed
the
copy_unroll_sdpa_to_npuw_llm_comp_model
branch
2 times, most recently
from
8964fa3 to
6332248
Compare
AsyaPronina
force-pushed
the
copy_unroll_sdpa_to_npuw_llm_comp_model
branch
from
6332248 to
9049565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: