Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::rot90 for pytorch models #24088

Open
mvafin opened this issue Apr 17, 2024 · 14 comments
Open

[Good First Issue]: Support aten::rot90 for pytorch models #24088

mvafin opened this issue Apr 17, 2024 · 14 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Apr 17, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

Please refer to decomposition of this operation in torch for hints how to implement with OpenVINO opset: https://github.com/pytorch/pytorch/blob/3f89f565bb17bcb70cb6938540af0cd154c8344a/torch/_refs/__init__.py#L3796

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

CVS-138770

@mvafin mvafin added the good first issue Good for newcomers label Apr 17, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Apr 17, 2024
@mvafin mvafin added category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Apr 17, 2024
@NavyaLingisetty
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Apr 18, 2024
@p-wysocki
Copy link
Contributor

Hello @NavyaLingisetty, are you still working on that issue? Do you need any help?

@parthrastogicoder
Copy link

@p-wysocki Can I help In this if it is not fixed ?

@NavyaLingisetty
Copy link

@p-wysocki Can I help In this if it is not fixed ?

Sure.

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Sep 18, 2024
@shivamgcodes
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Sep 24, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Nov 6, 2024

hey @shivamgcodes - do you need any support or you don't have to finish this task?

@shivamgcodes
Copy link

yea , i was stuck in a couple places .. i got the help i needed in the discord group. will make sure to submit a pr within the next 3 days
sorry for the delay

@shivamgcodes shivamgcodes removed their assignment Dec 1, 2024
@shivamgcodes
Copy link

sorry, i just could not solve it.

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Dec 2, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Dec 2, 2024

do not worry :)
we do have plenty other tasks to pick up, maybe some other will be more convinient for you?

@shivamgcodes
Copy link

yea, i will take a look at the repository and search for more suitable issues. Thanks.

@Po-V
Copy link

Po-V commented Dec 10, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

No branches or pull requests

7 participants