Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::rrelu and aten::rrelu_ for pytorch models #23746

Open
mvafin opened this issue Mar 28, 2024 · 11 comments
Open

[Good First Issue]: Support aten::rrelu and aten::rrelu_ for pytorch models #23746

mvafin opened this issue Mar 28, 2024 · 11 comments
Assignees
@AdamPSU
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 28, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

This is a randomized operation, but it is randomized only when training, for OpenVINO we assume that models are in inference only mode, so randomization is not needed. Due to that this op is actually similar to torch.nn.LeakyReLU

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

CVS-136484
@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 28, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 28, 2024
@mvafin mvafin changed the title [Good First Issue]: Support aten::aminmax for pytorch models [Good First Issue]: Support aten::rrelu and aten::rrelu_ for pytorch models Mar 28, 2024
@Increshi
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Mar 28, 2024
@Increshi
Copy link

@mvafin Do I need to implement two ops rrelu and rrelu_ ? If yes What is the difference between both functions in implementation ?

@Increshi Increshi mentioned this issue Mar 29, 2024
Closed
@Increshi
Copy link

@mvafin Could you please take a look at the above pull request? Happy to make changes if suggested.

@mlukasze mlukasze linked a pull request Apr 2, 2024 that will close this issue
[PT FE] Add aten::rrelu and aten::rrelu_ for pytorch models #23773
Closed
@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Apr 2, 2024
@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Jun 18, 2024
@TRIGON69
Copy link

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Aug 12, 2024
@mlukasze
Copy link
Contributor

hey @TRIGON69 any help needed?

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Nov 6, 2024
@AdamPSU
Copy link

AdamPSU commented Nov 8, 2024

.take

Hello! Looking to get started with OpenVINO. If this issue is still available, I'll be glad to put my name on it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Nov 8, 2024
@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Nov 8, 2024
@mlukasze mlukasze moved this from In Review to Assigned in Good first issues Nov 8, 2024
@AdamPSU AdamPSU mentioned this issue Nov 13, 2024
Open
@AdamPSU AdamPSU removed their assignment Nov 19, 2024
@AdamPSU
Copy link

AdamPSU commented Nov 22, 2024

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdamPSU AdamPSU

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Status: Assigned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PT FE] Add aten::rrelu and aten::rrelu_ for pytorch models Increshi/openvino
5 participants
@mvafin @mlukasze @AdamPSU @TRIGON69 @Increshi