Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::where(cond) for pytorch models #23745

Open
mvafin opened this issue Mar 28, 2024 · 12 comments
Open

[Good First Issue]: Support aten::where(cond) for pytorch models #23745

mvafin opened this issue Mar 28, 2024 · 12 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 28, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

Currently this use case is unsupported:

PYTORCH_OP_CONVERSION_CHECK(!context.input_is_none(1), "aten::where(cond) unsupported");

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

CVS-136483

@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 28, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 28, 2024
@vdizhenin
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Mar 29, 2024
@Aryan8912
Copy link
Contributor

It's been two weeks since this issue was opened. Can you assign it to me?

@vdizhenin
Copy link

No, I'm still working on it

@p-wysocki
Copy link
Contributor

Hello @vdizhenin, are you still working on that issue? Do you need any help?

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Jul 25, 2024
@rishi-sangare
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Aug 23, 2024
@mlukasze
Copy link
Contributor

hey @rishi-sangare any help needed?

@rishi-sangare rishi-sangare removed their assignment Oct 7, 2024
@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Nov 6, 2024
@gatbontonp
Copy link

Hi! I'm relatively new to open source. Can I try and work this?

@gatbontonp
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki
Copy link
Contributor

@gatbontonp Hi, thanks for taking the issue! Please let us know if you have any questions or need help. :)

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

No branches or pull requests

7 participants