Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::reflection_pad1d, aten::reflection_pad3d for pytorch models #23321

Open
mvafin opened this issue Mar 7, 2024 · 10 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Mar 7, 2024

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.
aten::reflection_pad2d is already supported, what needs to be done is to also support other sizes.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Mar 7, 2024
@thinhngo-x
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@thinhngo-x
Copy link

Hello @mvafin, can you please show me where the aten::reflection_pad2dhas been implemented? Thanks.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Mar 11, 2024
@mvafin
Copy link
Contributor Author

mvafin commented Mar 11, 2024

@thinhngo-x It is supported here:

} else if ((pad_op = cast_fw_node(m.get_match_root(), "aten::reflection_pad2d"))) {

@p-wysocki
Copy link
Contributor

Hello @thinhngo-x, are you still working on this?

@p-wysocki p-wysocki moved this from Assigned to Contributors Needed in Good first issues May 6, 2024
@duydl
Copy link
Contributor

duydl commented May 14, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues May 15, 2024
@duydl
Copy link
Contributor

duydl commented May 15, 2024

Hi, I have some question.

Thank you.

@duydl duydl removed their assignment Jun 11, 2024
@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Jul 25, 2024
@jagadeeshmadinni
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

No branches or pull requests

5 participants