Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::is_nonzero for pytorch models #20582

Closed
mvafin opened this issue Oct 18, 2023 · 2 comments · Fixed by #20589
Closed

[Good First Issue]: Support aten::is_nonzero for pytorch models #20582

mvafin opened this issue Oct 18, 2023 · 2 comments · Fixed by #20589
Assignees
@siddhant-0707
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Milestone
2023.2

Comments

@mvafin
Copy link
Contributor

mvafin commented Oct 18, 2023 •
edited
Loading

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD
@mvafin mvafin added good first issue Good for newcomers no_stale Do not mark as stale labels Oct 18, 2023
@github-project-automation github-project-automation bot moved this to Contrubutors needed in Good first issues Oct 18, 2023
@ilya-lavrenov ilya-lavrenov added the category: PyTorch FE OpenVINO PyTorch Frontend label Oct 18, 2023
@siddhant-0707 siddhant-0707 mentioned this issue Oct 18, 2023
Merged
@andrei-kochin andrei-kochin moved this from Contrubutors needed to Assigned in Good first issues Oct 19, 2023
@andrei-kochin
Copy link
Contributor

@siddhant-0707 thanks for your contribution!
Please kindly drop a comment here so I can assign this to you

@andrei-kochin andrei-kochin moved this from Assigned to In review in Good first issues Oct 19, 2023
@siddhant-0707
Copy link
Contributor

Please assign me the issue 👍

@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Oct 27, 2023
@mlukasze mlukasze added this to the 2023.2 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddhant-0707 siddhant-0707

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Archived in project
Milestone
2023.2
Development

Successfully merging a pull request may close this issue.

[PT FE] Add aten::is_nonzero siddhant-0707/openvino
5 participants
@ilya-lavrenov @siddhant-0707 @mvafin @mlukasze @andrei-kochin