Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled per-channel propagation #2511

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Feb 22, 2024

Changes

  • Disabled propagation of the per-channel activation quantizers;

Reason for changes

  • Correct quantizer propagation;

Related tickets

  • 131890

Tests

  • TBD

@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.95%. Comparing base (edd397b) to head (c8efe7f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2511       +/-   ##
============================================
- Coverage    90.83%   36.95%   -53.88%     
============================================
  Files          498      498               
  Lines        45621    45582       -39     
============================================
- Hits         41438    16845    -24593     
- Misses        4183    28737    +24554     
Files Coverage Δ
...ommon/quantization/quantizer_propagation/solver.py 83.33% <100.00%> (-10.45%) ⬇️
...mmon/quantization/quantizer_propagation/structs.py 100.00% <100.00%> (ø)

... and 359 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.79% <83.33%> (+0.05%) ⬆️
ONNX 34.80% <100.00%> (+0.03%) ⬆️
OPENVINO ?
TENSORFLOW ?
TORCH ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 68.55% <100.00%> (-25.21%) ⬇️
torch 32.97% <ø> (-60.46%) ⬇️
tensorflow 0.00% <ø> (-93.73%) ⬇️
onnx 93.05% <ø> (ø)
openvino 0.00% <ø> (-94.07%) ⬇️
ptq 44.14% <ø> (-43.60%) ⬇️

@KodiaqQ KodiaqQ marked this pull request as ready for review February 22, 2024 18:35
@KodiaqQ KodiaqQ requested a review from a team as a code owner February 22, 2024 18:35
@KodiaqQ KodiaqQ removed the request for review from a team February 22, 2024 18:35
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment for this PR:

  • Require performance testing on a wide range of models as FQ placement changes.

@KodiaqQ KodiaqQ marked this pull request as draft February 23, 2024 07:33
@KodiaqQ KodiaqQ force-pushed the nm/disable_per_channel_propagation branch from c8fccf4 to c8efe7f Compare March 8, 2024 11:50
@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Mar 8, 2024
@KodiaqQ KodiaqQ closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants