Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset.filter doesn't count removed items #257

Closed
zhiltsov-max opened this issue May 31, 2021 · 0 comments · Fixed by #297
Closed

Dataset.filter doesn't count removed items #257

zhiltsov-max opened this issue May 31, 2021 · 0 comments · Fixed by #297
Labels
BUG Something isn't working

Comments

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented May 31, 2021

Since #102, Dataset.filter() and other transform operations can produce dataset patches, which include a list of removed items. However, they do not count items removed by transforms (and filters), only direct removal with .remove() is counted.

How to reproduce:

  1. Create a Dataset
  2. Call Dataset.filter / Dataset.transform, which excludes some items
  3. Check Dataset.patch

Dataset.patch is expected to have some items marked removed.

@zhiltsov-max zhiltsov-max added the BUG Something isn't working label May 31, 2021
@zhiltsov-max zhiltsov-max mentioned this issue Jun 4, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant