Skip to content

Commit

Permalink
fix: update package detail page for git tag ignore
Browse files Browse the repository at this point in the history
  • Loading branch information
favoyang committed Jan 5, 2020
1 parent 5c945ef commit 2d39871
Showing 1 changed file with 29 additions and 15 deletions.
44 changes: 29 additions & 15 deletions docs/.vuepress/theme/layouts/PackageDetail.vue
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@
</section>
<section class="col-12">
<h2>Project</h2>
<div><NavLink :item="repoNavLink" /></div>
<div>
<span><NavLink :item="repoNavLink"/></span>
</div>
<div v-if="parentRepoNavLink" class="fork">
forked from
<NavLink :item="parentRepoNavLink" />
Expand Down Expand Up @@ -145,10 +147,12 @@
>
<div class="col-6">
<i :class="build.class"></i>
{{ build.build.version }}
<span>{{ build.build.version }}</span>
</div>
<div class="col-6">
{{ build.timeSince }}
<span>
{{ build.timeSince }}
</span>
</div>
</li>
</ul>
Expand All @@ -161,13 +165,15 @@
<h2>Build Issues</h2>
<div v-if="noTagsFound" class="toast">
<p>
No tags found in <NavLink :item="tagsNavLink" />. Please
checkout docs
<a
href="/docs/adding-upm-package.html#handling-repository-without-releases"
>
handling repository without releases.
</a>
<span>
No tags found in <NavLink :item="tagsNavLink" />. Please
checkout docs
<a
href="/docs/adding-upm-package.html#handling-repository-without-releases"
>
handling repository without releases.
</a>
</span>
</p>
</div>
<div class="container">
Expand All @@ -179,16 +185,19 @@
>
<div class="col-6">
<i :class="build.class"></i>
{{ build.id }}
<span>{{ build.id }}</span>
</div>
<div class="col-6">
<a
v-if="build.build.buildId"
:href="build.buildUrl"
target="_blank"
build="noopener noreferrer"
>{{ build.text }}</a
>
<span>
{{ build.text }}
</span>
</a>
<span v-else>{{ build.text }}</span>
</div>
</li>
Expand All @@ -198,12 +207,14 @@
<section v-if="packageInvalidTags.length" class="col-12">
<h2
class="tooltip tooltip-top"
data-tooltip="These tags are ignored by build pipelines"
data-tooltip="Tags are non-semver, duplicated or ignored."
>
Non-semver / duplicated tags
Invalid tags
<i class="fa fa-info-circle"></i>
</h2>
<div>{{ packageInvalidTagsString }}</div>
<div>
<span>{{ packageInvalidTagsString }}</span>
</div>
</section>
<section class="col-12">
<h2>Badge <small>(click to copy)</small></h2>
Expand Down Expand Up @@ -586,6 +597,9 @@ See more in the [${this.$package.repo}](${this.$package.repoUrl}) repository.
a, h2, p, span, ul, li, div.toast
font-size 0.75rem
span, span a
font-size 0.7rem
div.toast
p
font-size 0.7rem
Expand Down

0 comments on commit 2d39871

Please sign in to comment.