Handle rlig for latin script #564
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added GPOS LookupType 4 parser for MarkBasePosFormat1 support - added GPOS LookupType 9 parser for Extension Positioning SubtableFormat1 support - tests coverage for all supported and not supported lookups of GPOS TODO: Add a support device offsets for anchor (Parser.anchor) table format 3.
- introduced an union, ordered features lookup list - refactored the Font options features update method - supported kerning table - supported kern lookup table - supported mark to base attachments
- fix for kern sequence - tests coverage
|
Good question... Both of them made changes to bidi.js which I also altered, and both of them could probably benefit from the common helper function that I introduced. I think it's easier to merge those two first and have me adapt the rlig code to those changes instead of heaving to incorporate mine into both of the PRs. |
# Conflicts: # src/bidi.js # src/features/arab/arabicRequiredLigatures.js # src/features/latn/latinLigatures.js
8 tasks
# Conflicts: # src/font.js # test/layout.js
# Conflicts: # src/font.js
…onFormat1 - substitution algorithm to match specficiation (lookup - apply - lookup - apply) - added support for multiSubstitutionFormat1 substitutions - updated applySubstitution method for more flexibility - tests coverage
Dev/eslint import no cycle
…o next/main # Conflicts: # .github/workflows/scripts/report-counter.js # .github/workflows/unicode-report.yml
…/github.com/Adylic/opentype.js into Adylic-feature/mark-to-base-attachment-positioning # Conflicts: # src/font.js
|
I somehow managed to mess up this branch... Going to convert to draft until I find time to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This handles the
rligfeature for latin scripts.Motivation and Context
Despite being enabled for latin scripts even by default,
rligligatures were only handled for Arabic script.I did some minor refactoring of the ligature application to diminish code duplication betweeen arabic and latin script ligatures and the new rlig implementation. They now use the same method in a new
src/features/commonFeatureUtils.jsfile, without breaking the existing file/module structure, with parameters for the script, feature and range. This might come in handy as we progress to implement new font features. Speaking of which, we should probably overhaul feature handling as we do so. This PR only enablesrligfor the latin script, which fixes #554 (and fixes #479), while other scripts might need it as well and there are other features that might not be script-specific.How Has This Been Tested?
Tested with the Pecita font provided in #479 and added corresponding tests for it (the font is under SIL Open Font License so I was able to use it directly for the tests), not breaking any other tests.
Screenshots (if appropriate):
before:
after (note the "qu" and "ck" shapes):
The rest of the differences to how it should look according to #479 can be attributed to not supporting the
caltfeature.Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).