Using IntermediatePlaces to a trip does not return a result if the Start and End are too close to each other.

[mmaranda-cs]

Expected behavior

I plan a route using intermediate places. The intermediate places are far away but the origin and destination of the route are close to each other or are the same place. I expect to be able to plan this kind of round trip behavior and have a valid request and response.

Observed behavior

Response does not return a route and includes the error: Origin is within a trivial distance of the destination

Version of OTP used (exact commit hash or JAR name)

Master

Data sets in use (links to GTFS and OSM PBF files)

New York was used in this example but any dataset will have this problem

Steps to reproduce the problem

Run a request with the following parameters in New York
fromPlace=40.608450000000005,-73.95725
toPlace=40.608450000000005,-73.95725
intermediatePlaces=40.608450000000005,-73.95725
mode=CAR

[t2gran]

+1 I think is ok to remove Origin/Destination distance check for searches with Intermediate places, instead the check should be applied to O-I, and I-D.

For the future we(Entur, Norway) have some loose thoughts about separating this functionality out of OTP into a new component, an orchestrator that can take a request and translate it into several parallell OTP requests and then merge the result and apply a pareto function to the result. This component could as its own component or as part of the OTP process. This is not discussed by the PLC, but I wanted to mention it in as it relates to this issue.

[optionsome]

I got rid of this issue in HSL fork by disabling the check in requests with intermediatePlaces (HSLdevcom@6b00a48). However, I was planning to replace it with a slightly smarter check that checks if any of the places that are directly linked to each other are on the same edge but haven't had time to implement it yet. This issue became relevant for us after we implemented a feature in our fork that allows to set locationSlack to intermediatePlaces in requests which defines the minimum time spent at an intermediate location.

[abyrd]

Let's subsume this into #3183 for OTP2, closing.