Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

ActiveSpan is too Opaque #208

Closed
3 tasks
rbtcollins opened this issue Oct 25, 2017 · 5 comments
Closed
3 tasks

ActiveSpan is too Opaque #208

rbtcollins opened this issue Oct 25, 2017 · 5 comments

Comments

@rbtcollins
Copy link

rbtcollins commented Oct 25, 2017

We'd like to be able to use the TraceId from the ActiveSpan in three additional contexts

  • In external logs, so we can silo sensitive data from the widely-accessed tracing console but still correlate
  • In response headers, so that we can do browser integration and directly link to the resulting trace from our UI for developers
  • In request headers when using external APIs that support correlation e.g with x-request-id, so that we can ask their support to examine a particular request.

Right now we cannot because traceId is considered an implementation detail, not part of the contract.

@devinsba
Copy link
Contributor

There is an ongoing discussion of this: opentracing/specification#24

@tedsuo
Copy link
Member

tedsuo commented Oct 31, 2017

I agree @rbtcollins, I want to push on this once #189 is over.

@cwe1ss
Copy link
Member

cwe1ss commented Mar 30, 2018

fyi, this is currently getting specified with opentracing/specification#109

@carlosalberto
Copy link
Collaborator

Wondering if we should close this Issue, as there's already an ongoing discussion (as Christian pointed out), as well as #280?

@rbtcollins ok to close it? ;)

@rbtcollins
Copy link
Author

Closed in favour of the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants