Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard config for signed app? #178

Closed
jaytarub opened this issue Sep 27, 2018 · 10 comments
Closed

Proguard config for signed app? #178

jaytarub opened this issue Sep 27, 2018 · 10 comments

Comments

@jaytarub
Copy link

  • what should we add in our proguard config when we signed the app?
@marinaserranomontes
Copy link
Contributor

Hi @jaytarub ,

As you observe, we have not included proguard in the samples. Having Proguard run is completely optional, but highly recommended. You can find more details in the Android doc: http://developer.android.com/guide/developing/tools/proguard.html

Best,
Marina

@marinaserranomontes
Copy link
Contributor

Hi @jaytarub ,

I’m closing this issue because it has been inactive for a few weeks.

Please reopen if you still encounter this issue. You can also contribute directly to samples by providing a patch.

Thank you!

Best,
Marina

@zhuosun-rally
Copy link

could you guide us how to config the opentok proguard? like what's the special class need be keep in proguard.

@RKSharma89
Copy link

Here are the proguard rules for OpenTok:
-keep class com.opentok.{ ; }
-keepclassmembers class com.opentok.
{ ; }
-dontwarn com.opentok.**
-keep class org.webrtc.* { ; }

@MinkiPani
Copy link

MinkiPani commented Dec 10, 2019

Here are the proguard rules for OpenTok:
-keep class com.opentok.{ ; }
-keepclassmembers class com.opentok.
{ ; }
-dontwarn com.opentok.**
-keep class org.webrtc.* { ; }

hello, these rules are way too broad, is basically says "don't touch any of the classes from my SDK"
could you please define the rules more fine grained for us?

@cdreyfus
Copy link

cdreyfus commented May 7, 2020

There's a mistake in the above rules:
-keep class org.webrtc.** { ; }
-dontwarn com.opentok.
*
-keep class com.opentok.** { *; }
-keepclassmembers class com.opentok.{ *; }

@palmas
Copy link

palmas commented May 22, 2020

This seems to be ok:

-keep class com.opentok.** { ; }
-keep class org.webrtc.
* { *; }

@dp85
Copy link

dp85 commented Jul 9, 2022

In 2.22.1 I also needed:

-keep class com.vonage.** { *; }

@mzekrallah
Copy link

With new vonage sdks, only this configuration will work:

-keep class com.opentok.** { ; }
-keep class com.vonage.
* { ; }
-keep class org.webrtc.
* { ; }
-keep class org.otwebrtc.
* { *; }

@DmytroBatyuk
Copy link

DmytroBatyuk commented Jul 2, 2024

These works for me

-keep class com.opentok.** { *; }
-keep class com.vonage.** { *; }
-keep class org.webrtc.** { *; }
-keep class org.otwebrtc.** { *; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants