-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proguard config for signed app? #178
Comments
Hi @jaytarub , As you observe, we have not included proguard in the samples. Having Proguard run is completely optional, but highly recommended. You can find more details in the Android doc: http://developer.android.com/guide/developing/tools/proguard.html Best, |
Hi @jaytarub , I’m closing this issue because it has been inactive for a few weeks. Please reopen if you still encounter this issue. You can also contribute directly to samples by providing a patch. Thank you! Best, |
could you guide us how to config the opentok proguard? like what's the special class need be keep in proguard. |
Here are the proguard rules for OpenTok: |
hello, these rules are way too broad, is basically says "don't touch any of the classes from my SDK" |
There's a mistake in the above rules: |
This seems to be ok: -keep class com.opentok.** { ; } |
In 2.22.1 I also needed: -keep class com.vonage.** { *; } |
With new vonage sdks, only this configuration will work: -keep class com.opentok.** { ; } |
These works for me
|
The text was updated successfully, but these errors were encountered: