Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] fix recent hotifx-regressions #937

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Hotfix] fix recent hotifx-regressions #937

wants to merge 5 commits into from

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Nov 7, 2024 •
edited
Loading

Hotfix due to accidental regression of previous hotfixes:

Context

Some regression of hotfixes occurred on mainnet from PR #914

@camfairchild
Hotfix/skip root for emission accum (#933)
694298a 
* skip netuid 0 for pending emission accum

* comment
@camfairchild
use chk for neuron info lite stake (#936)
212c998
@camfairchild
Hotfix/clear stake delta on drain (#934)
40d13ce 
* add comment also

* chore: fmt

* add back delta handling in helpers

* track removals in stake delta

* handle stake delta in ck swap func

* add tests back

* add tests for staking back

* add back test for ck swap
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Nov 7, 2024
@camfairchild
respect chk for set weights min stake filter (#935)
acba156 
* respect chk for set weights min stake filter

* use for test func

* respect chk in set weights call also

* add tests back

* fix weights min stake tests also
@camfairchild
bump spec
eb1af3c
@camfairchild camfairchild changed the title Hotfix/skip root for emission accum (#933) [Hotfix] fix recent hotifx-regressions Nov 7, 2024
@gztensor gztensor mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gztensor gztensor gztensor approved these changes

@distributedstatemachine distributedstatemachine distributedstatemachine approved these changes

@unconst unconst Awaiting requested review from unconst unconst is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camfairchild @distributedstatemachine @gztensor