Metagraph contract #1043
Merged
Metagraph contract #1043
+891
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-junius
added
no-spec-version-bump
gztensor
requested changes
Dec 5, 2024
runtime/src/precompiles/metagraph.rs
Outdated
|
|
||
| match method_id { | ||
| id if id == get_method_id("getUidCount(uint16)") => Self::get_uid_count(&method_input), | ||
| id if id == get_method_id("getIsSubnetRegistered(uint16)") => { |
There was a problem hiding this comment.
Move this method to subnets precompile. It will be implemented in the issue #1067
| @@ -13,10 +13,12 @@ use pallet_evm_precompile_simple::{ECRecover, ECRecoverPublicKey, Identity, Ripe | |||
| // Include custom precompiles | |||
| mod balance_transfer; | |||
| mod ed25519; | |||
| mod metagraph; | |||
There was a problem hiding this comment.
METAGRAPH_PRECOMPILE_INDEX also needs to be in used_addresses so that is_precompile works correctly.
sam0x17
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pr will close #1032 , create a precompile contract to get the metagraph data via eth rpc.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.