Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for childkey stake when setting weights #917

Closed
2 tasks
gztensor opened this issue Nov 5, 2024 · 2 comments
Closed
2 tasks

Check for childkey stake when setting weights #917

gztensor opened this issue Nov 5, 2024 · 2 comments
Assignees

Comments

@gztensor
Copy link
Contributor

gztensor commented Nov 5, 2024

The set_weights extrinsic, as well as commit_weights are checking if the weight setting hotkey has enough stake.

but both check using check_weights_min_stake, which uses TotalColdkeyStake. We need to modify check_weights_min_stake so that it considers parent/child stake.

Acceptance criteria:

  • Update check_weights_min_stake
  • Unit test or e2e test for each path that sets weights
@gztensor
Copy link
Contributor Author

gztensor commented Nov 6, 2024

PR: #924

@gztensor
Copy link
Contributor Author

gztensor commented Nov 7, 2024

Addressed by #935 (by @camfairchild )

@gztensor gztensor closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants