[1.8.0-rc3] Crash when new or revert to saved after apply measure now to a model.

[jmarrec]

Issue overview

• Reported by @LNikdel on v1.8.0-rc3 Testing: Call for help from the community #743

Current Behavior

The application crashes and closes unexpectedly when attempting to perform File > "New," "Open," or "Revert to Saved" after applying a measure to an open mod

Expected Behavior

Shouldn't crash!

Steps to Reproduce

I was able to reproduce on a Clean Windows 10 20H2 VM with the following steps:

1. Open OpenStudioApp 1.8.0-rc3
2. Do File > Example > Example Model
3. Save the model.
4. Find Measure on BCL, download "Exterior wall thermal properties percent change" (a random measure)
5. Do "Apply Measure Now" (I'm on the "Site / Location" tab still)
6. Apply that Exterior Wall Thermal Percent Change with 15 for Exterior wall Total R-value Percentage Change
7. Accept changes
8. Model is marked as changed because I haven't saved it, but I do "File > Revert to Saved" with Discard changes
9. It crashes, and the OpenStudio CLI process is orphaned!

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

• Platform (Operating system, version): At least Windows 10, 22H2 and 20H2
• Version of OpenStudioApplication (if using an intermediate build, include SHA): 1.8.0-rc3

[jmarrec]

Couple of datapoints:

• It works on Ubuntu 24.04 (I even attached a debugger)
• On Windows, if I revert to saved when I did a change but not apply a measure, it doesn't crash.
• On Windows, if I "Apply Now", save the model, do another change (Change Calendar Year for eg) and Revert to saved, it still crashes.
• On Windows, OPENSTUDIO_APPLICATION_DEBUG=1 doesn't reveal useful info, will need a debugger.

[jmarrec]

I think this may be fixed via this PR as I couldn't reproduce it by building locally...

• Fix #747 - crash shoebox #748

[jmarrec]

Confirmed I do not get the crash by using the latest installer from develop https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/10723955812