Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crash when using Python measures without Python Bindings component installed #656

Closed
macumber opened this issue Dec 27, 2023 · 3 comments · Fixed by #720
Closed

Comments

@macumber
Copy link
Collaborator

Issue overview

Attempting to drag a Python measure into a workflow will throw an exception if the Python bindings are not installed.

Current Behavior

Instead of showing an error, the uncaught exception will prompt the user to restart the application or close it, appearing like a crash.

Expected Behavior

Measure should be seen with an arguments can't be computed error or something similar instead of an app crash.

Steps to Reproduce

  1. Install OpenStudio Application without Python bindings
  2. Create a Python measure
  3. Drag Python measure into workflow

Possible Solution

Catch the error and display error instead of throwing exception.

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Windows 11
  • Version of OpenStudioApplication (if using an intermediate build, include SHA): 1.7.0-rc1
@jmarrec
Copy link
Collaborator

jmarrec commented Jan 11, 2024

FWIW, I think the same thing happens in the OS SDK CLI.

@macumber
Copy link
Collaborator Author

Partially addressed this by changing the default to install Python bindings in https://github.com/openstudiocoalition/OpenStudioApplication/pull/662/files

@macumber macumber removed this from the OpenStudio Application 1.7.0 milestone Jan 22, 2024
@macumber
Copy link
Collaborator Author

Related to #671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants