Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openstudio application crashes after clicking on thermal zone tab #554

Closed
Nischal0150 opened this issue Jun 27, 2022 · 11 comments
Closed

Openstudio application crashes after clicking on thermal zone tab #554

Nischal0150 opened this issue Jun 27, 2022 · 11 comments

Comments

@Nischal0150
Copy link

Issue overview

I am using Openstudio 3.40 to model a building with 50 thermal zones. But every time I click on the thermal zone tab on Openstudio, the application stalls for a few seconds and then crashes abruptly.

Current Behavior

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): windows 10
  • Version of OpenStudioApplication 1.4

Context

@Nischal0150 Nischal0150 added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jun 27, 2022
@macumber
Copy link
Collaborator

Moved from NREL/OpenStudio#4617

@Nischal0150 Would you be able to post the model here (you can rename it to a .txt extension and upload it to the issue) or send it privately to [email protected]?

@Nischal0150
Copy link
Author

Moved from NREL/OpenStudio#4617

@Nischal0150 Would you be able to post the model here (you can rename it to a .txt extension and upload it to the issue) or send it privately to [email protected]?

I have sent the model to [email protected]

@macumber
Copy link
Collaborator

macumber commented Jun 28, 2022

Thanks @Nischal0150, I can reproduce the crash. I think this has something to do with NUM_ROWS_PER_GRIDLAYOUT in OSGridView.cpp which is currently set at 50.

@macumber
Copy link
Collaborator

macumber commented Jun 28, 2022

Another odd thing seems to be that the ThermalZones are missing an inletPortList, was this OSM created through some script or other process? Did it use the OS SDK to create the ThermalZone objects? If you used the OpenStudio SketchUp Plug-in, what version of the plug-in and what version of the OS Application is the plug-in pointed at?

@macumber
Copy link
Collaborator

macumber commented Jun 28, 2022

Possibly related to #414. The "Add New Thermal Zone For Spaces With No Thermal Zone" seems to be calling the right ThermalZone constructor https://github.com/openstudiocoalition/openstudio-sketchup-plugin/blob/develop/plugin/openstudio/user_scripts/Alter%20or%20Add%20Model%20Elements/Add_New_Thermal_Zone_For_Spaces_With_No_Thermal_Zone.rb#L62

@macumber macumber added severity - Normal Bug 🐛 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 28, 2022
@Nischal0150
Copy link
Author

Yes, the thermal zones were created through openstudio user script using openstudio sketchup plugin V 1.4.0

@macumber
Copy link
Collaborator

Hmm, I was not able to reproduce this using SketchUp 2021 on Windows 11, OpenStudio SketchUp Plug-in 1.4.0, OpenStudio Application 1.4.0, and OpenStudio SDK 1.4.0

image

Can you check your OpenStudio SketchUp Plug-in preferences to make sure that you have the plug-in pointed at the right OpenStudio Application version?

image

@macumber
Copy link
Collaborator

I can't reproduce this (by making a new model in the SketchUp Plug-in and running the "Add New Thermal Zone For Spaces With No Thermal Zone" user script with 1.5.0-rc.1 either. I'm going to close this issue, we can re-open it if we know how the zones were created without the necessary port objects. The code in the OS ThermalZone constructor hasn't changed for 7 years.

@lutareeem
Copy link

lutareeem commented Aug 28, 2023

Windows 10
OS Application 1.2.1
OS 3.6.1

Same thing is happening - click on a group to change thermal zone, it gives me this:

RuntimeError
bad allocation
BACKTRACE:
C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/DialogManager.rb:321:in setIddObjectType' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/DialogManager.rb:321:in selection_changed'
C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/interfaces/MaterialsInterface.rb:374:in rendering_mode=' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/dialogs/SpaceAttributesInterface.rb:238:in block in module:OpenStudio'
C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:262:in block in process_events' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:255:in each'
C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:255:in process_events' C:/Users/admin/AppData/Roaming/SketchUp/SketchUp 2021/SketchUp/Plugins/openstudio/lib/PluginManager.rb:318:in block in start_event_processing'

And when I click on Thermal Zones in the Inspector it crashes. It gives me the same error when I click on Render by Thermal Zone. I've tried different versions and I'm still getting it?

@macumber macumber reopened this Sep 2, 2023
@macumber
Copy link
Collaborator

macumber commented Sep 2, 2023

@lutareeem are you using the same model as before? Do your ThermalZone objects have valid Zone Air Inlet Port List and Zone Air Exhaust Port List fields?

Here is a ThermalZone from the last example model I got from you in a text editor:
image

Here is a ThermalZone from a correct model for reference:
image

@macumber
Copy link
Collaborator

macumber commented Sep 9, 2023

Re-closing until we get more information

@macumber macumber closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants