Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text too large on OSItems #536

Closed
macumber opened this issue May 11, 2022 · 5 comments · Fixed by #540
Closed

Text too large on OSItems #536

macumber opened this issue May 11, 2022 · 5 comments · Fixed by #540

Comments

@macumber
Copy link
Collaborator

Enhancement Request

The text on OSItems seems larger than it used to be

Detailed Description

Comparison of 1.4.0 vs 1.3.0

image

Possible Implementation

Adjust stylesheet for OSItem

@macumber
Copy link
Collaborator Author

Overall changes in Qt 6 seem like they are making better use of UI real estate

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 3, 2022

The biggest issue here is that on 1.4.0 there's an extra "Airplane mode off" overlay that we didn't have in 1.3.0 :)

@macumber macumber added this to the OpenStudio Application 1.4.1 milestone Jun 8, 2022
@macumber
Copy link
Collaborator Author

macumber commented Jun 8, 2022

The tab icons are a bit blurry on my resolution after #535

@jmarrec I don't see the "Airplane mode off" overlay, is that an Ubuntu thing?

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 8, 2022

The overlay mention was a joke, it's in your screenshot but I know that's windows/your laptop and not the osapp

Screenshot_20220609-004516_Firefox.jpg

We can look into the icons being blurry, but I'd rather have them a bit blurry than have 2 drop-downs out of 3 being out of place.

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 8, 2022

As a reminder from #540, the move might be helpful to investigate this without the overhead of building and running a large project. And the Qt ticket we should monitor

See this MCVE: https://github.com/jmarrec/QtTestbed/tree/main/Test-Combobox-Popup-Issue

And the bug report I filed at Qt's issue tracker: https://bugreports.qt.io/browse/QTBUG-104073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants