Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'x2' button to clone Plant Loops in HVAC Systems tab #487

Closed
eringold opened this issue Feb 9, 2022 · 2 comments · Fixed by #488
Closed

Enable 'x2' button to clone Plant Loops in HVAC Systems tab #487

eringold opened this issue Feb 9, 2022 · 2 comments · Fixed by #488
Labels
component - UI Enhancement Request New feature or request good first issue Good for newcomers

Comments

@eringold
Copy link
Contributor

eringold commented Feb 9, 2022

Enhancement Request

@jmarrec gave us a working PlantLoop::clone method, but as far as I can tell it's not implemented in OSApp - clicking the 'x2' icon when viewing a plant loop in the HVAC Systems tab does nothing.

(v1.3.0+5faa91ea6b)

@eringold eringold added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 9, 2022
@jmarrec jmarrec added good first issue Good for newcomers component - UI and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 10, 2022
@jmarrec
Copy link
Collaborator

jmarrec commented Feb 10, 2022

@eringold it's a very easy change,

void HVACSystemsController::onCopySystemClicked() {
auto loop = currentLoop();
if (loop) {
auto airloop = loop->optionalCast<model::AirLoopHVAC>();
if (airloop) {
auto clone = airloop->clone(loop->model());
setCurrentHandle(toQString(clone.handle()));
}
}
}

A great first issue, wanna give it a shot 😉?

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 10, 2022

Note you don't even need to check if it's an airloophvac anymore. If loop: loop->clone() is enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - UI Enhancement Request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants