Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No rendering color for Foundation surfaces in Geometry Viewer #290

Closed
macumber opened this issue Jan 4, 2021 · 4 comments · Fixed by NREL/OpenStudio#4580
Closed

No rendering color for Foundation surfaces in Geometry Viewer #290

macumber opened this issue Jan 4, 2021 · 4 comments · Fixed by NREL/OpenStudio#4580
Assignees
@macumber
Labels
component - Geometry Editor good first issue Good for newcomers severity - Minor Bug 🐤
Milestone
OpenStudio Applic...

Comments

@macumber
Copy link
Collaborator

macumber commented Jan 4, 2021

NREL/openstudio-common-measures-gem#53
@macumber macumber added Triage Issue needs to be assessed and labeled, further information on reported might be needed component - Geometry Editor good first issue Good for newcomers severity - Minor Bug 🐤 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jan 4, 2021
@macumber macumber added this to the OpenStudio Application 1.3.0 milestone May 29, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented Jun 1, 2021

Is there anything to do on the app side here @macumber ?

@macumber
Copy link
Collaborator Author

macumber commented Jun 2, 2021

We'd want to include this in the embedded viewer when we do #357

@macumber macumber changed the title No rendering color for Foundation surfaces No rendering color for Foundation surfaces in Geometry Viewer Jul 22, 2021
@macumber macumber self-assigned this Apr 29, 2022
@macumber macumber mentioned this issue Apr 30, 2022
Merged
19 tasks
@jmarrec
Copy link
Collaborator

jmarrec commented May 3, 2022

@macumber Now that NREL/OpenStudio#4580 is merged, do we need to do something here?

@macumber
Copy link
Collaborator Author

macumber commented May 4, 2022

Nope that is all here! I do want to get all of @antoine-galataud's fixes back into the https://github.com/NREL/openstudio-common-measures-gem/ ViewData and ViewModel measures though.

@macumber macumber closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macumber macumber

Labels
component - Geometry Editor good first issue Good for newcomers severity - Minor Bug 🐤
Projects
None yet
Milestone
OpenStudio Application 1.4.0
Development

Successfully merging a pull request may close this issue.

Add color for Foundation boundary condition openstudiocoalition/OpenStudio
2 participants
@macumber @jmarrec