Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the right-hand pane on Schedules editable #286

Closed
LouYingli opened this issue Dec 14, 2020 · 8 comments
Closed

Make the right-hand pane on Schedules editable #286

LouYingli opened this issue Dec 14, 2020 · 8 comments
Labels
Enhancement Request New feature or request

Comments

@LouYingli
Copy link

Enhancement Request

Make the right-hand pane on Schedules editable.

Detailed Description

The right-hand pane on Schedules cannot be edited. In some applications, such as large-scale simulations, users would need to edit them.
image

@LouYingli LouYingli added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Dec 14, 2020
@macumber
Copy link
Collaborator

I think this is a duplicate of #271, do you agree @LouYingli ?

@LouYingli
Copy link
Author

I think this is not a duplicate of #271. #271 suggests that the right-hand pane on Schedules is in read-only mode. I think that's why I can't edit the right-hand pane on Schedules now. I have a different opinion with #271. I think we should make the right-hand pane on Schedules editable.

@macumber
Copy link
Collaborator

The values displayed in the right hand pane under edit on the schedules tab are the day schedule values that are editable in the main gui area. The values in the right hand pane are not editable because we would have to redraw the schedule view in the main gui every time one of those values changed. Also we would have to support adding and deleting values from the day schedule in the right hand pane. So those values are intentionally read only on that tab.

@LouYingli
Copy link
Author

Thank you for the clarification. I agree that the Schedule Type Limits Name, Interpolate to Timestop, Hour, Minute, and Value Until Time in the right-hand pane do not need to be editable. Because we can edit this information in the main gui area. But the Name of the ScheduleDay should be editable. For example, as shown in the following figure, the Name of the ScheduleDay is "Schedule Day 2". I want to modify the Name of the ScheduleDay as "Office Bldg Occ Sat Day". But I cannot modify it in the OS app.

image

@macumber
Copy link
Collaborator

Oh ok, I see, thanks for clarifying. Yes, editing the name of the day schedule seems reasonable. Would it meet your needs if we just did that on the schedule editing tab and not in the edit/inspector?

@LouYingli
Copy link
Author

Sorry. What is the schedule editing tab refer to? Do you mean the left-hand pane (in the following figure)? I think it may be easier to make the Name of the ScheduleDay in the right-hand-pane editable.
image

@macumber
Copy link
Collaborator

I'd suggest adding it right on top of the day schedule that is being edited

image

@LouYingli
Copy link
Author

I see. It's a very good option.

@macumber macumber removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Feb 14, 2021
@macumber macumber added this to the OpenStudio Application 1.2.0 milestone Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants