Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Model list does not show cooling towers #269

Closed
Ski90Moo opened this issue Nov 11, 2020 · 5 comments
Closed

My Model list does not show cooling towers #269

Ski90Moo opened this issue Nov 11, 2020 · 5 comments

Comments

@Ski90Moo
Copy link

Issue overview

My Model list does not show cooling towers

Current Behavior

2020-11-11

Expected Behavior

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudioApplication (if using an intermediate build, include SHA):

Context

@Ski90Moo Ski90Moo added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Nov 11, 2020
@macumber macumber added severity - Major Bug 💥 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Nov 24, 2020
@macumber macumber added this to the OpenStudio Application 1.2.0 milestone Nov 24, 2020
@jmarrec jmarrec self-assigned this Feb 4, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2021

@macumber @Ski90Moo Does it really make sense to have it show on "My Model List"?

The fix is easy, but usually stuff you see in "My Model List" on the loops tab is because either:

  • This is a component you define somewhere else (eg a children of a ZoneHVAC object)
  • This is component that can be added to 2+ loops, so that when you drag it from the library it gets added to its primary loop, but then you can drag it from the My model to add it to the secondary (or tertiary) PlantLoop/AirLoopHVAC

A cooling tower belongs on ONE loop only, so it falls it neither category.

I'm leaning towards closing as "Works as expected"

@Ski90Moo
Copy link
Author

Ski90Moo commented Feb 4, 2021

It is helpful in order to duplicate the component without adding to the library. So, for example, if I drag in a cooling tower from the library and then proceed to customize it, it becomes part of My Model. Then, if I want to have two more just like it, I would drag two more from the My Model and drop onto the loop. Maybe I am doing it wrong?

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2021

That's not how it works though. clone() method is called only when you drag from "Library", not from "My Model".

In My Model, it would be calling plantLoop.addToNode(object) instead, thus disconnecting it from any previous loops.

It would be a different feature request to allow cloning HVAC Components. (this is something I would personally do via the ruby bindings...)

@Ski90Moo
Copy link
Author

Ski90Moo commented Feb 4, 2021

Ok, my mistake.

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2021

No worries. The feature of being able to clone an hvac equipment is valid though. You can open a separate feature request for it. And if you can think of a good way to have that in the UI even better (right now I can't really think of one)

@jmarrec jmarrec closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants