Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FanZoneExhaust schedule fields disabled in App for objects created with API #254

Open
MatthewSteen opened this issue Oct 15, 2020 · 1 comment

Comments

@MatthewSteen
Copy link

Issue overview

FanZoneExhaust objects created with the API have two schedule fields disabled in the App. Objects added to a model in the App are fine. Found in 2.9.0, but I assume it's present in newer versions based on a quick look at git blame. NREL/OpenStudio#4116

Current Behavior

image

Expected Behavior

image

Steps to Reproduce

require 'openstudio'
include OpenStudio::Model
m = Model.new
tz = ThermalZone.new(m)
fze = FanZoneExhaust.new(m)
fze.addToThermalZone(tz)
m.save
  1. Open model and add FanZoneExhaust to zone with an object from the library

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Windows 10
  • Version of OpenStudio (if using an intermediate build, include SHA): 2.9.0

Context

@MatthewSteen MatthewSteen added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Oct 15, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 15, 2020

Either:

  • OpenStudio changes it's Constructor just to please the OSApp and initializes this field, which makes no sense now post-separation of SDK and App (hence why I closed the original FanZoneExhaust schedule fields disabled in App for objects created with API NREL/OpenStudio#4116) , but which is the way we've always handled that stuff in the past
  • You ensure you initialize these fields (workaround)
  • Or, we change the overall InspectorGadget behavior to deal with defaulted / uninitialized fields. We could add a flag in OpenStudioPolicy.xml to force display some fields perhaps.

@jmarrec jmarrec added component - Backend component - UI Enhancement Request New feature or request and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants