Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #225

Closed
macumber opened this issue Aug 29, 2020 · 4 comments
Closed

Update CI #225

macumber opened this issue Aug 29, 2020 · 4 comments

Comments

@macumber
Copy link
Collaborator

macumber commented Aug 29, 2020

Enhancement Request

Provide an easy way to switch CI builds between official NREL OS packages and interim packages with changes from the OSC fork .

Detailed Description

We want to be able to reliably update the version of OS used in the app build, including the ability to use packages with interim changes that are not yet in NREL's official builds.

Possible Implementation

  • Implement github actions for the OSC fork (is there a way to prevent these from being pulled back to NREL?)
  • Have OSC fork post packages as GitHub actions artifacts, do not want to post these as releases as that would cause confusion
@macumber macumber added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Aug 29, 2020
@macumber macumber added this to the OpenStudio Application 1.1.0 milestone Aug 29, 2020
@macumber
Copy link
Collaborator Author

macumber commented Aug 30, 2020

Alternative 1

Use case 1: official NREL/OpenStudio package is available with everything OS App needs

  • OS App builds against official NREL package, this is preferred

Use case 2: OSC has open PRs to NREL/OpenStudio with changes needed in OS App

  • All OSC PRs consolidated on openstudiocoalition/OpenStudio/develop
  • Merge openstudiocoalition/OpenStudio/tree/develop into Merge openstudiocoalition/OpenStudio/tree/ci-builder
  • Wait for packages to be built by GitHub actions, stored as artifacts on GitHub actions
  • OS App builds against packages on GitHub actions until NREL package is available

Alternative 2

Use case 1: official NREL/OpenStudio package is available with everything OS App needs

  • OS App builds against official NREL package, this is preferred

Use case 2: OSC has open PRs to NREL/OpenStudio with changes needed in OS App

  • All OSC PRs consolidated on openstudiocoalition/OpenStudio/develop
  • Make PR from openstudiocoalition/OpenStudio/develop to nrel/OpenStudio/develop
  • Add label "Ready for CI" to PR
  • Wait for packages to be built by NREL CI, stored as artifacts on AWS
  • OS App builds against packages on AWS until NREL package is available

@macumber
Copy link
Collaborator Author

I think we should go with Alternative 2 above for now

@macumber macumber mentioned this issue Aug 30, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 1, 2020

I'm working on this.

@jmarrec jmarrec self-assigned this Sep 1, 2020
@jmarrec jmarrec added Developer Issue 🤓 severity - Blocker 🚫 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Sep 1, 2020
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 1, 2020

Fixed it in #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants