Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you change an object tagged as "BCL" it doesn't loose the tag when you alter it (Bugzilla #724) #130

Open
axelstudios opened this issue Jul 19, 2013 · 4 comments

Comments

@axelstudios
Copy link
Contributor

On 2012-06-07 13:14:35, @DavidGoldwasser wrote:

Tested this with schedule set, schedule ruleset, space type, and lights def. I don't know that this is in scope for 0.8.0, but I just wanted to document it.

I also tried to reload the file to make sure that didn't update the graphic.

On 2012-09-13 16:00:45, @DavidGoldwasser wrote:

Per Elaine's request I tested this by deleting an attached object (like a removing people instance from a space type). Results were the same.

If this isn't an easy fix, then I think it can wait until post 0.9.0, just wanted to consider if it was low hanging fruit.

@ghost ghost assigned evanweaver Jul 19, 2013
@DavidGoldwasser
Copy link
Contributor

I'll add feature flag to this, and show as minor, but it is still important to fix this. In particular related to CEC work where we hope to make use of components, but want to know when they have been altered. @macumber I assume you feel this is important to keep in. Currently low frequency, but that won't always be the case if we start leaning on components more.

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 29, 2017

Fixed in OS 2.2.1. If I delete a material from a BCL construction, the BCL tags gets removed (at least when I switch to another tab and come back)

@DavidGoldwasser
Copy link
Contributor

@jmarrec, I'm not seeing that on Mac 2.3.0. I can't do anything to get rid of the BCL flag. First tried changing material prop, then threw the material away, left and came back to material.

@jmarrec
Copy link
Collaborator

jmarrec commented Oct 3, 2017

Ah yes, it works with Construction, not with Material.
If I delete a material from a BCL Construction, the Construction BCL tag disappears.
Doesn't work for the Material indeed.

@jmarrec jmarrec assigned jmarrec and unassigned evanweaver Feb 27, 2019
@jmarrec jmarrec transferred this issue from NREL/OpenStudio May 13, 2020
@jmarrec jmarrec removed their assignment May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants