Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Feature says Bad Request #1843

Closed
ghost opened this issue Apr 30, 2018 · 8 comments
Closed

Query Feature says Bad Request #1843

ghost opened this issue Apr 30, 2018 · 8 comments

Comments

@ghost
Copy link

ghost commented Apr 30, 2018

Since some days now, the Query Feature feature consistently fails with Error contacting https://overpass-api.de/api/interpreter: Bad Request.

The query it appears to be sending is (split on multiple lines and indented):

[timeout:10][out:json];
(
  node(around:10,40.68925,-74.04454);
  way(around:10,40.68925,-74.04454)
);
out+tags+geom(40.688320248612015,-74.04532760381699,40.69015880670406,-74.04373168945312);
relation(around:10,40.68925,-74.04454);
out+geom(40.688320248612015,-74.04532760381699,40.69015880670406,-74.04373168945312);
@tomhughes
Copy link
Member

Unfortunately that service is outside our control - all we can do is send it queries and hope.

@tomhughes tomhughes reopened this Apr 30, 2018
@tomhughes
Copy link
Member

So I assumed you meant a general failure of the overpass service but actually it's only one of the queries that is failing, and it is actually reporting an error if you dig a bit deeper in the inspector:

Error: line 1: parse error: ';' expected - ')' found.
Error: line 1: parse error: Unexpected end of input.
Error: line 1: static error: Element "print" cannot be subelement of element "union".
Error: line 1: static error: Element "print" cannot be subelement of element "union". 

I have no idea what it means though... I assume that the initial segment is the "union" but I have no idea which item is the "print" it is complaining about.

@tomhughes
Copy link
Member

Ah I think it wants a semicolon after the second entry in the union.

@mmd-osm
Copy link
Contributor

mmd-osm commented Apr 30, 2018

Yes, the semicolon was missing. Roland deployed version 0.7.55 on one of the two production servers earlier today, and this version has a slightly more restrictive syntax check with regards to the union statement. The other server currently still runs on 0.7.54, so there's like a 50% chance you would hit this issue today.

Edit: May 1st: both production servers are on 0.7.55 now.

I applied pretty much the same change to a number of examples on the Overpass by Example page in the wiki.

@ghost
Copy link
Author

ghost commented Apr 30, 2018

So I assumed you meant a general failure of the overpass service

Err yeah, my bad, I wasn't clear. I had seen the more detailed error messages but I had forgotten to write about them.

@westnordost
Copy link

Hmm, if 0.7.55 introduces changes that make previously-working queries fail, shouldn't it be named 0.8.0 then?

@mmd-osm
Copy link
Contributor

mmd-osm commented May 1, 2018

Overpass uses a different versioning schema: this is really a change from 0.7.54.13 to 0.7.55 (.0).

@drolbr
Copy link
Contributor

drolbr commented May 7, 2018

I'm sorry. If was of course not intended to break things.

However, the omission of the semicolon never was intended as valid syntax. And I never checked that that worked and that anybody used that. I'm sorry for the inconvenience. Thank you, M1dgard for reporting the thing and thank you, Tom, for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants