Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese address preset #2252

Merged
merged 2 commits into from
Jun 15, 2014
Merged

Vietnamese address preset #2252

merged 2 commits into from
Jun 15, 2014

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Jun 15, 2014

Much of the addresses in Vietnam in OSM are either incomplete or malformed. From a glance at overpass turbo, virtually all them were entered using iD and JOSM, which both present the same address fields. For example:

  • This way includes the provincial route number, ward, arrondissement, city, and country in addr:city.
  • This POI includes the street, ward, and arrondissement in addr:street.
  • This POI places the city in addr:city but the ward and arrondissement in addr:postcode.
  • This way makes use of the name and addr:postcode fields to encode the full housenumber (see the discussion on alleys below).

Most of the remaining addresses simply don’t bother with anything beyond the street, which makes it hard for Nominatim to give decent results in large cities where the third-level administrative boundaries haven’t been mapped and the wards aren’t perfect circles.

The problem stems from the limited number of fields available in iD’s and JOSM’s address presets. Vietnamese addresses in urban areas typically have more components than you’d find in a North American address, for example. So mappers tend to stuff the full address into one of the fields they see. iD can help stem this problem by providing better presets.

Vietnamese address formats are based on the administrative hierarchy, which varies between rural and urban areas. This org chart shows the relationships between all the officially recognized administrative units in Vietnam. Not all levels need to be included in every given street address, but the order will always go from smallest to largest in the org chart. Based on the existing (well-formed) addresses and wiki documentation, the full tagging scheme for each possible Vietnamese address format would be:

  • 123 housenumber Street street, Ward subdistrict, Arrondissement district, Municipality city 123456 postcode
  • 123 housenumber Street street, Ward subdistrict, Town district, Municipality city 123456 postcode
  • 123 housenumber Street street, Commune subdistrict, Town district, Municipality city 123456 postcode
  • 123 housenumber Street street, Commune subdistrict, District district, Municipality city 123456 postcode
  • 123 housenumber Street street, Townlet subdistrict, District district, Municipality city 123456 postcode
  • 123 housenumber Street street, Ward subdistrict, Town city, Province province 123456 postcode
  • 123 housenumber Street street, Commune subdistrict, Town city, Province province 123456 postcode
  • 123 housenumber Street street, Commune subdistrict, District district, Province province 123456 postcode
  • 123 housenumber Street street, Townlet subdistrict, District district, Province province 123456 postcode
  • 123 housenumber Street street, Ward subdistrict, Provincial City city, Province province 123456 postcode
  • 123 housenumber Street street, Commune subdistrict, Provincial City city, Province province 123456 postcode

Therefore, I think it makes sense to lay out iD’s address preset like this (with English translations of the Vietnamese translations already in Transifex):

housenumber street   # 123 Street
subdistrict          # Ward/Commune/Townlet
district             # Arrondissement/Town/District
city                 # City/Town
province    postcode # Province Postcode

Everything is on its own line to ensure that the placeholder text fits at all window sizes. This is also how addresses are written on post in Vietnam.

One caveat is that street addresses on alleys in urban areas include the name of the collector street and any alleys needed to reach the address. For example:

  • 64B Ngõ 51 Lương Khánh Thiện” lies on Alley 51, Luong Khanh Thien Street.
  • The house number sign “205/39/66” is for Number 66 on Alley 39 off Alley 205 off Tran Van Dang Street.

There seems to be no consensus on whether to include the extra alley numbers in addr:housenumber or addr:street, so I wouldn’t worry about accommodating them for the time being.

1ec5 added 2 commits June 14, 2014 16:11
Accounts for both rural and urban address formats.
Nothing in Vietnam uses addr:suburb, and it seems to be intended to be subordinate to addr:district and addr:subdistrict, which means it definitely doesn’t map to thị xã. I also found some examples using addr:district for thị xã. So addr:district should be used for both quận and thị xã in a municipality.

The resulting placeholder text will be rather long, and Vietnamese mail tend to have each component on a separate line, so I also split subdistrict, district, and city onto separate lines.
jfirebaugh added a commit that referenced this pull request Jun 15, 2014
Vietnamese address preset
@jfirebaugh jfirebaugh merged commit 8f3f9c3 into openstreetmap:master Jun 15, 2014
@1ec5 1ec5 deleted the patch-1 branch June 17, 2014 09:41
@1ec5 1ec5 mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants