Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Kneipp Water Cure preset #7332

Merged
merged 3 commits into from
Feb 6, 2020
Merged

added Kneipp Water Cure preset #7332

merged 3 commits into from
Feb 6, 2020

Conversation

animesh-007
Copy link
Contributor

added Kneipp Water Cure preset fixes #7313

@bhousel
Copy link
Member

bhousel commented Feb 6, 2020

Can you rename the facility.json file to kneipp_water_cure_multi.json and make it like this?

{
    "key": "kneipp_water_cure:",
    "type": "multiCombo",
    "label": "Basin Types"
}

This will make it a combo for picking the different kneipp_water_cure:* tags. (The way you have it, iD would try to use a facility tag for this, which is wrong).

@animesh-007
Copy link
Contributor Author

@bhousel I have committed the suggested changes.

@bhousel
Copy link
Member

bhousel commented Feb 6, 2020

@bhousel I have committed the suggested changes.

I still see a facility file. can you git rm it ?

@bhousel
Copy link
Member

bhousel commented Feb 6, 2020

looks good @animesh-007 , thanks for sticking with it! 👍

@bhousel bhousel merged commit 7d4c513 into openstreetmap:2.x Feb 6, 2020
@animesh-007
Copy link
Contributor Author

Thanks for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kneipp_water_cure - Icon and more fields needed
3 participants