Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple access to advertising #7289

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Add simple access to advertising #7289

merged 2 commits into from
Feb 3, 2020

Conversation

ToastHawaii
Copy link
Contributor

"Who can change the content of the board?" option added based on the Wiki page.

@quincylvania
Copy link
Collaborator

@ToastHawaii Hmm the meaning of this field seems ambiguous on these… I could also assume it refers to who can view or approach the feature.

@quincylvania quincylvania added the considering Not Actionable - still considering if this is something we want label Jan 26, 2020
@ToastHawaii
Copy link
Contributor Author

@quincylvania Thanks for pointing that out. I add the visibility tag and moved the access tag to the more field section. I think this helps to improve the clarity.

Both are part of the documentation on the wiki pages eg. for board https://wiki.openstreetmap.org/wiki/Tag%3Aadvertising%3Dboard. The access property was add for 3 years.
Based on the taginfo the access tag is used many times in comination mit advertising https://taginfo.openstreetmap.org/keys/advertising#combinations

Do you think it needs more? Is there anything I can do to make it less ambiguous?

@quincylvania quincylvania merged commit 1fd3e15 into openstreetmap:2.x Feb 3, 2020
@quincylvania quincylvania added preset An issue with an OpenStreetMap preset or tag and removed considering Not Actionable - still considering if this is something we want labels Feb 3, 2020
@quincylvania quincylvania added this to the Next Release milestone Feb 3, 2020
@quincylvania
Copy link
Collaborator

@ToastHawaii Okay, if people are using this tag then it seems okay to have it under moreFields. Thanks for understanding 🤙

@ToastHawaii
Copy link
Contributor Author

@quincylvania Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants