Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts panel uses some Windows key names on macOS #4073

Closed
1ec5 opened this issue Jun 1, 2017 · 10 comments
Closed

Keyboard shortcuts panel uses some Windows key names on macOS #4073

1ec5 opened this issue Jun 1, 2017 · 10 comments

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jun 1, 2017

On macOS, the keyboard shortcuts panel displays some Windows key names that differ from what appears on most Mac key caps (although it does get the symbols right):

  • ↵ Enter should be ↵ Return. (⌤ Enter is a separate key that doesn’t always do the same thing as ↵ Return, although it does in iD. On non-extended keyboards manufactured in the last ten years or so, it’s mapped to Fn↵ Return, which is a pain to type.)
  • ⌥ Alt should be ⌥ Option (Modern keyboards also say “Alt” in small text on the Option key, and many localized keyboards omit “Option”, so this isn’t a big deal.)
@1ec5
Copy link
Collaborator Author

1ec5 commented Jun 1, 2017

↨ Pause is inscrutable. I believe you can use F15 on an extended keyboard, but I’m not sure what the equivalent is on a non-extended keyboard, which lacks F15.

@bhousel
Copy link
Member

bhousel commented Jun 1, 2017

Just so I understand - are you suggesting we change the labels for everyone for better clarity, or adjust the labels depending on detected OS (swap Return / Enter or Alt / Option). I'm ok with either choice, as long as it makes things easier to understand.

↨ Pause is weird - I've never seen that symbol before but I took it from iD shortcuts page on OSM Wiki. I guess it doesn't hurt to show it since all the other nearby keys have inscrutable symbols too. At least they are consistent.

I've never seen a F15 key, so probably safe to leave it off.
(Similarly, I intentionally left off ☰ Menu as Right-click to conserve space)

screenshot 2017-06-01 13 50 24

@1ec5
Copy link
Collaborator Author

1ec5 commented Jun 1, 2017

are you suggesting we change the labels for everyone for better clarity, or adjust the labels depending on detected OS (swap Return / Enter or Alt / Option).

The latter: for macOS, show ↩ Return and ⌥ Option.

↨ Pause is weird - I've never seen that symbol before but I took it from iD shortcuts page on OSM Wiki. I guess it doesn't hurt to show it since all the other nearby keys have inscrutable symbols too. At least they are consistent.

The was added in this edit. I’m not sure where it came from; Wikipedia’s version once used , but that was removed for being apocryphal.

macOS does have a standard set of keyboard symbols for display in menus (so “⌘⇧S” instead of “Command-Shift-S”). However, Mac keyboards have no Pause button. A Mac running Windows via Bootcamp can use fn⎋ Esc, but there doesn’t appear to be anything like it in macOS. So I guess there’s a second issue here: the vast majority of Macs have no way to switch parent ways.

@bhousel
Copy link
Member

bhousel commented Jun 2, 2017

So I guess there’s a second issue here: the vast majority of Macs have no way to switch parent ways.

No its ok, backslash \ will switch parent ways! That's actually the original and most convenient way to do it on a US mac keyboard.

The PgUpPgDnHomeEndPause alternatives were added here #3539 (comment) as a workaround for non-US non-Mac keyboard layouts

@1ec5
Copy link
Collaborator Author

1ec5 commented Jun 2, 2017

Ah! In that case, we could simply hide Pause on macOS.

@bhousel
Copy link
Member

bhousel commented Jun 2, 2017

Ah! In that case, we could simply hide Pause on macOS.

I don't mind showing it.. It probably won't confuse anybody and I sometimes use an external Logitech keyboard with my Mac, which includes that key.

@bhousel
Copy link
Member

bhousel commented Jun 2, 2017

Worth mentioning that this screen does weird things on Windows because of how iD.cmdUi substitutes keys. I'm probably going to just split up the keys and the modifiers and make a new function that produces more display-focused output.

keyboard_shortcuts

@bhousel bhousel mentioned this issue Jun 3, 2017
1 task
@bhousel bhousel added the wip Work in progress label Jun 4, 2017
@bhousel
Copy link
Member

bhousel commented Jun 5, 2017

done with #4080

@bhousel bhousel closed this as completed Jun 5, 2017
@bhousel bhousel removed the wip Work in progress label Jun 5, 2017
@bhousel
Copy link
Member

bhousel commented Jun 6, 2017

I've never seen a F15 key, so probably safe to leave it off.

Oh look what landed in my email this morning

screenshot 2017-06-06 10 28 54

  • goes up to F19
  • Still 2 delete keys 🙄
  • fn where insert should be?
  • clear where num lock should be?

@1ec5
Copy link
Collaborator Author

1ec5 commented Jun 7, 2017

Yay, trivia time:

  • The macOS standard library can express key events up to F35.
  • Whereas most platforms refer to Backspace and Delete, Mac documentation always refers to Delete and Forward Delete.
  • Fn replaced the traditional Help key (?⃝) on Mac keyboards a decade ago. Clear has always been there.
  • Also a decade ago, MacBook Pro keyboards had Num Lock and most of the numpad mapped to Fn combinations, while Enter sat between the right Command and the left arrow key, where the right Option sits today.

More about Macintosh keyboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants