Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough - line - does not allow you to complete #3695

Closed
Nick-Tallguy opened this issue Dec 29, 2016 · 3 comments
Closed

Walkthrough - line - does not allow you to complete #3695

Nick-Tallguy opened this issue Dec 29, 2016 · 3 comments
Labels
bug A bug - let's fix this! walkthrough-help An issue with the walkthrough or help pane

Comments

@Nick-Tallguy
Copy link

Nick-Tallguy commented Dec 29, 2016

walkthrough-line

Following the walkthrough - not possible to complete the line item as it does not recognise that you have joined to Flower Street.

I've also tried this from 'the other end' - starting with a node on Flower Street and going North, but again it still does not recognise that I have made a junction with Flower Street.

@bhousel bhousel added bug A bug - let's fix this! walkthrough-help An issue with the walkthrough or help pane labels Dec 30, 2016
@bhousel
Copy link
Member

bhousel commented Feb 2, 2017

Looking carefully at the code and at your screencast, I think I might know what happened. It looks like you had already gone through this step in the tutorial already, and there is a leftover node at the junction, and you are able to connect your new way to the existing node (which normally wouldn't be there), and this confuses the tutorial.

I was able to reproduce this by performing this step, then deleting the line and trying the step over again.

@Nick-Tallguy
Copy link
Author

Thanks for investigating this.

I've just had another try and can't reproduce my earlier problem. I've started with the 'line' section of the walkthrough and completed that section without a problem. I'm using the same computer, OS & web browser as I was before.

Whatever was the problem seems to have disappeared now.

I suggest this issue is closed now, unless you have a reason to keep it open.

Thanks again.

@bhousel bhousel closed this as completed in ff1b16c Feb 3, 2017
@bhousel
Copy link
Member

bhousel commented Feb 3, 2017

I improved the code so that it should better catch line intersections now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! walkthrough-help An issue with the walkthrough or help pane
Projects
None yet
Development

No branches or pull requests

2 participants