Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong focus on preset search #1277

Closed
bussed opened this issue Apr 9, 2013 · 3 comments
Closed

Wrong focus on preset search #1277

bussed opened this issue Apr 9, 2013 · 3 comments

Comments

@bussed
Copy link

bussed commented Apr 9, 2013

On OSX / Safari

I create a new area.
I leave draw mode (clicking on area mode again).
I select the drawn area.
"Ribbon" shows up with Del / Q / O / etc options (this is really cool btw)

But the focus is now in the preset search text field. So q/o/.. shortcuts dont work.
I have to select an preset first to get the keyboard shortcuts working.

This behaviour confused me a bit. I would have expected the keyboard shortcuts "to work" in this situation.

@tmcw
Copy link
Contributor

tmcw commented Apr 9, 2013

This doesn't seem wrong to me: iD focuses on getting users to enter a preset first and thus focuses the preset search area until they have enough tags to be valid features - even if you leave the feature selection and return to it. Once a feature has enough tags to be valid, or a preset selected, clicking on it will not focus the preset search area.

@tmcw tmcw closed this as completed Apr 9, 2013
@bussed
Copy link
Author

bussed commented Apr 9, 2013

Hmm, i think it is not uncommon that you first want to get the geometry correct (with the help of pressing o or q) and then - as a last step - add a preset. Often i draw several buildings geom and then apply a preset to them at last.
But this is just how i use to map.

@jfirebaugh
Copy link
Member

Yes, I think we should auto-focus the search field only right after finishing drawing. At that point, the radial menu isn't shown anyway. So then the flow for correcting geometry before assigning a preset would be:

  1. Draw
  2. Finish drawing (either by esc or return key, or clicking the starting/ending node)
  3. Now search field is focused, no radial menu is open
  4. Click again to reselect the feature and show menu
  5. Now the search field should be blurred (this is what should change from current behavior)

In other words: when the menu is shown, search should not be focused. When search is focused, the menu should not be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants