Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Street level imagery: Viewer overlaps right click menu #10495

Open
danieldegroot2 opened this issue Oct 11, 2024 · 5 comments
Open

Street level imagery: Viewer overlaps right click menu #10495

danieldegroot2 opened this issue Oct 11, 2024 · 5 comments
Labels
good first issue Best for first-time contributors. No experience necessary!

Comments

@danieldegroot2
Copy link
Contributor

URL

No response

How to reproduce the issue?

Observed behaviour

  1. Enable street level imagery
  2. Select an image to view
  3. Create an object
  4. Move the map manually so the object is above the street level imagery viewer [1]
  5. Right click on the object
  6. The right click / edit menu and associated hover tooltips are partially obscured by the street level imagery viewer

Expected behaviour
The right click / edit menu and tooltips are moved in front of the viewer.
Additionally the orientation of the menu could be changed to horizontal so it does not overlap the viewer.

Related #7368


[1]; can be useful, as it is closer to the user's reading direction as well as being closer to the 'Tag this photo id on the currently selected map feature'.

Screenshot(s) or anything else?

image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome

@1ec5 1ec5 added the good first issue Best for first-time contributors. No experience necessary! label Oct 15, 2024
@FrankOHara43
Copy link

hi, can you please specify how to open street level imagery? As a new contributor I am finding it difficult to find that option. Also, I am interested in working on this issue.

@1ec5
Copy link
Collaborator

1ec5 commented Oct 17, 2024

Hi @FrankOHara43, thanks for your interest. The screenshot above shows the Mapillary image overlay, which you can enable from the Photo Overlays section of the Map Data pane (accessible from the strip of buttons on the right side of the map). You’ll need to zoom into a location that has Mapillary imagery, such as https://ideditor.netlify.app/#map=20.43/39.28200/-84.28412&photo=mapillary/172552988091232.

If you haven’t used iD before, please go to https://ideditor.netlify.app/ (or go to https://www.openstreetmap.org/, create a free account, zoom in to your neighborhood, and click Edit), and follow the on-screen tutorial.

@danieldegroot2
Copy link
Contributor Author

Ref #10504.

@tyrasd
Copy link
Member

tyrasd commented Oct 17, 2024

This can also happen with the info panels on the bottom right part of the screen. I guess the easiest solution would be to render the right click menu over all UI elements (as one would expect from regular OS context menus). #10504 (comment) has some pointers for how to approach this issue should @FrankOHara43 not like to continue working on this.

@FrankOHara43
Copy link

i am interested to continue working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Best for first-time contributors. No experience necessary!
Projects
None yet
Development

No branches or pull requests

4 participants