Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on building=roof #10470

Open
alesarrett opened this issue Sep 20, 2024 · 2 comments
Open

Warning on building=roof #10470

alesarrett opened this issue Sep 20, 2024 · 2 comments

Comments

@alesarrett
Copy link

URL

No response

How to reproduce the issue?

When creating a building=roof, iD is raising a warning if a layer=1 is not entered, even if the roof is not intersecting any other feature.
Anyway in the wiki is clear that layer=1 should be used when 2 or more features overlap, to express vertical positioning. Also the wiki page for roof is describing the use of the key layer only when roof is overlapping with something else: https://wiki.openstreetmap.org/wiki/Tag:building%3Droof
So, why this requirement and warning on iD?

Screenshot(s) or anything else?

Screenshot_20240920_115017

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Firefox

@k-yle
Copy link
Collaborator

k-yle commented Oct 13, 2024

This change was introduced in openstreetmap/id-tagging-schema#227

@alesarrett
Copy link
Author

Thank you for the reference, but that issue pertains to cases where a highway is located behind the roof. If the warning is applied as a default for all building=roof, inexperienced users may add a layer=1 unnecessarily, which does not align with the guidelines provided in the wiki. Could the warning be implemented only when the roof intersects with an already existing highway? This would effectively draw the user's attention when it is truly needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants