-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
width=0,1
saved as width=1
in locales that use a period as the decimal separator, such as English and Chinese
#10018
Comments
apparently it may depend on something, reportedly does not happen in German locale |
In locales that use a comma as the decimal separator, such as German, the fix in #8769 (comment) ensures that both “0,1” and “0.1” produce |
width=0,1
saved as width=1
width=0,1
saved as width=1
in locales that use a period as the decimal separator, such as English and Chinese
updated title note that some people use locales that does not match exactly their preferences as proper one may be unavailable For example on computer I use EN / EN-UK / EN-USA to have communicates in English, what helps in search based on error messages and reduces my urges to fix bad translations to Polish that I would otherwise encounter. On phone I was able to select EN-Germany (so I do not get miles as unit or weird number separators). |
While you’re right that some non-English speakers use the English locale, probably many more English speakers use the English locale. In English, the comma functions as the digit grouping character, and the user has no reason to believe that digit grouping characters function as decimal separators. If I enter 3,1, I may be in the middle of entering I think a more robust, less surprising fix for both cases would be to ignore the digit grouping character when the user inputs it, but still include it when formatting a number for display. There may be some edge cases due to the discrepancy between input and output characters. |
URL
No response
How to reproduce the issue?
create node
tag
barrier=bollard
add
width=0,1
trigger confusion involving several people - see https://community.openstreetmap.org/t/what-width-0-can-mean-here/106666 https://www.openstreetmap.org/changeset/142886665 https://www.openstreetmap.org/note/3994430
Screenshot(s) or anything else?
tried search for
comma
andwidth
in open issues here and tagging schemaWhich deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.27.3
Which browsers are you seeing this problem on?
Firefox
The text was updated successfully, but these errors were encountered: