Social Facility preset improvements

(closes #3702) * Add `social facility` field * Make sure Social Facility presets have both `social_facility` and `social_facility:for` * Change `social_facility:for` from radio to combo, because so many choices
openstreetmap · Dec 31, 2016 · e9dfa04 · e9dfa04
1 parent 9033c9d
commit e9dfa04
Show file tree

Hide file tree

Showing 11 changed files with 48 additions and 64 deletions.
diff --git a/data/presets.yaml b/data/presets.yaml
@@ -1062,11 +1062,12 @@ en:
           very_horrible: 'Specialized off-road: tractor, ATV'
         # smoothness field placeholder
         placeholder: 'Thin Rollers, Wheels, Off-Road...'
+      social_facility:
+        # social_facility=*
+        label: Type
       social_facility_for:
         # 'social_facility:for=*'
-        label: People served
-        # social_facility_for field placeholder
-        placeholder: 'Homeless, Disabled, Child, etc'
+        label: People Served
       source:
         # source=*
         label: Source

diff --git a/data/presets/fields.json b/data/presets/fields.json
@@ -1409,25 +1409,13 @@
         },
         "social_facility_for": {
             "key": "social_facility:for",
-            "type": "radio",
-            "label": "People served",
-            "placeholder": "Homeless, Disabled, Child, etc",
-            "options": [
-                "abused",
-                "child",
-                "disabled",
-                "diseased",
-                "drug_addicted",
-                "homeless",
-                "juvenile",
-                "mental_health",
-                "migrant",
-                "orphan",
-                "senior",
-                "underprivileged",
-                "unemployed",
-                "victim"
-            ]
+            "type": "combo",
+            "label": "People Served"
+        },
+        "social_facility": {
+            "key": "social_facility",
+            "type": "combo",
+            "label": "Type"
         },
         "source": {
             "key": "source",

diff --git a/data/presets/fields/social_facility.json b/data/presets/fields/social_facility.json
@@ -0,0 +1,5 @@
+{
+    "key": "social_facility",
+    "type": "combo",
+    "label": "Type"
+}
diff --git a/data/presets/fields/social_facility_for.json b/data/presets/fields/social_facility_for.json
@@ -1,23 +1,5 @@
 {
     "key": "social_facility:for",
-    "type": "radio",
-    "label": "People served",
-    "placeholder": "Homeless, Disabled, Child, etc",
-    "options": [
-    	"abused",
-    	"child",
-    	"disabled",
-    	"diseased",
-    	"drug_addicted",
-    	"homeless",
-    	"juvenile",
-    	"mental_health",
-    	"migrant",
-    	"orphan",
-    	"senior",
-    	"underprivileged",
-    	"unemployed",
-    	"victim"
-    ]
-
-} 
+    "type": "combo",
+    "label": "People Served"
+}
diff --git a/data/presets/presets.json b/data/presets/presets.json
@@ -2109,9 +2109,10 @@
                 "operator",
                 "address",
                 "building_area",
+                "social_facility",
+                "social_facility_for",
                 "opening_hours",
-                "wheelchair",
-                "social_facility_for"
+                "wheelchair"
             ],
             "geometry": [
                 "point",
@@ -2128,8 +2129,9 @@
                 "operator",
                 "address",
                 "building_area",
-                "opening_hours",
-                "social_facility_for"
+                "social_facility",
+                "social_facility_for",
+                "opening_hours"
             ],
             "geometry": [
                 "point",
@@ -2147,9 +2149,10 @@
                 "operator",
                 "address",
                 "building_area",
+                "social_facility",
+                "social_facility_for",
                 "opening_hours",
-                "wheelchair",
-                "social_facility_for"
+                "wheelchair"
             ],
             "geometry": [
                 "point",
@@ -2172,9 +2175,10 @@
                 "operator",
                 "address",
                 "building_area",
+                "social_facility",
+                "social_facility_for",
                 "opening_hours",
                 "wheelchair",
-                "social_facility_for",
                 "internet_access",
                 "internet_access/fee",
                 "internet_access/ssid"

diff --git a/data/presets/presets/amenity/crematorium.json b/data/presets/presets/amenity/crematorium.json
@@ -5,15 +5,14 @@
         "phone",
         "opening_hours",
         "wheelchair"
-
     ],
     "geometry": [
-        "area", 
+        "area",
         "point"
     ],
     "tags": {
         "amenity": "crematorium"
     },
     "terms": ["cemetery","funeral"],
     "name": "Crematorium"
-}
+}
diff --git a/data/presets/presets/amenity/social_facility.json b/data/presets/presets/amenity/social_facility.json
@@ -3,16 +3,16 @@
         "operator",
         "address",
         "building_area",
+        "social_facility",
+        "social_facility_for",
         "opening_hours",
-        "wheelchair",
-        "social_facility_for"
+        "wheelchair"
     ],
     "geometry": [
         "point",
         "area"
     ],
-    "terms": [
-    ],
+    "terms": [],
     "tags": {
         "amenity": "social_facility"
     },

diff --git a/data/presets/presets/amenity/social_facility/food_bank.json b/data/presets/presets/amenity/social_facility/food_bank.json
@@ -3,8 +3,9 @@
         "operator",
         "address",
         "building_area",
-        "opening_hours",
-        "social_facility_for"
+        "social_facility",
+        "social_facility_for",
+        "opening_hours"
     ],
     "geometry": [
         "point",

diff --git a/data/presets/presets/amenity/social_facility/group_home.json b/data/presets/presets/amenity/social_facility/group_home.json
@@ -3,9 +3,10 @@
         "operator",
         "address",
         "building_area",
+        "social_facility",
+        "social_facility_for",
         "opening_hours",
-        "wheelchair",
-        "social_facility_for"
+        "wheelchair"
     ],
     "geometry": [
         "point",

diff --git a/data/presets/presets/amenity/social_facility/homeless_shelter.json b/data/presets/presets/amenity/social_facility/homeless_shelter.json
@@ -3,9 +3,10 @@
         "operator",
         "address",
         "building_area",
+        "social_facility",
+        "social_facility_for",
         "opening_hours",
         "wheelchair",
-        "social_facility_for",
         "internet_access",
         "internet_access/fee",
         "internet_access/ssid"

diff --git a/dist/locales/en.json b/dist/locales/en.json
@@ -1607,8 +1607,10 @@
                     }
                 },
                 "social_facility_for": {
-                    "label": "People served",
-                    "placeholder": "Homeless, Disabled, Child, etc"
+                    "label": "People Served"
+                },
+                "social_facility": {
+                    "label": "Type"
                 },
                 "source": {
                     "label": "Source"