Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting a PR to an issue in Zenhub should update the description in the issue #59

Open
kerwinso opened this issue Aug 13, 2018 · 3 comments
Assignees

Comments

@kerwinso
Copy link

kerwinso commented Aug 13, 2018

For release tracking, we are using Zenhub, and for the CNX team's purposes, we need a separate issue in GitHub tracking each PR.

When connecting a PR to an issue in Zenhub, is it possible for staxly to automatically update that issue's description with a link to that PR?

Example:

  1. In support filters cnx-archive#569, I click 'connect with an issue' and connect it to https://github.com/Connexions/cnx-db/issues/136.
  2. In https://github.com/Connexions/cnx-db/issues/136, the description is automatically updated to include the following text:
# PRs
https://github.com/Connexions/cnx-archive/pull/569

(The 'connect a PR to an issue' functionality is Zenhub-only, this screenshot is from my Chrome browser with the Zenhub extension installed:)

image

@staxly
Copy link

staxly bot commented Aug 13, 2018

👋 Thanks for opening your first issue here! If you're reporting a bug (🐛), please make sure you include steps to reproduce it.

@philschatz
Copy link
Member

@kerwinso In openstax/cnx-archive#569 was the Depends on Connexions/cnx-db#132 added by a person or by ZenHub?

If it was added by ZenHub then it might be possible. If it was not done by ZenHub then it might not be possible as-described since the linking information is stored in ZenHub.

However, if someone manually adds Depends on #123 to the PR description then Staxly could easily update the description of #123 to include what is described above, namely that the bottom of the description of #123 contains something like:

# Related Pull Requests

- https://github.com/Connexions/cnx-archive/pull/569

@kerwinso
Copy link
Author

@philschatz The Depends on Connexions/cnx-db#132 in openstax/cnx-archive#569 was added by a person (Mulich to be exact).

The behavior you propose would help connect a PR to another PR, but I'm also concerned about updating issues that need auto-linking from PRs.

Maybe Staxly can just look for any issue number (#123) inside the PR description, and add a link from that PR to the linked issue's description in the manner you describe above. This may work for linking to both PRs and issues (I believe from the data POV, Github issue links are the same as PR links).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants